public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix sequence number assignment for PS response frames
Date: Mon, 12 Sep 2016 11:58:47 +0200	[thread overview]
Message-ID: <1473674327.29016.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20160904160059.66297-1-nbd@nbd.name> (sfid-20160904_180104_088886_B2893E34)

On Sun, 2016-09-04 at 18:00 +0200, Felix Fietkau wrote:
> When using intermediate queues, sequence number allocation is
> deferred
> until dequeue. This doesn't work for PS response frames, which bypass
> those queues.
> 
Applied.

This worries me a bit though - there's nothing, afaict, that guarantees
that dequeue and real TX are not concurrent, and that would corrupt a
number of things, no?

johannes

  reply	other threads:[~2016-09-12  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04 16:00 [PATCH] mac80211: fix sequence number assignment for PS response frames Felix Fietkau
2016-09-12  9:58 ` Johannes Berg [this message]
2016-09-12 10:01   ` Felix Fietkau
2016-09-12 10:03     ` Johannes Berg
2016-09-12 10:05       ` Felix Fietkau
2016-09-12 10:07         ` Johannes Berg
2016-09-12 10:08           ` Felix Fietkau
2016-09-12 10:56             ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473674327.29016.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox