From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Felix Fietkau <nbd@nbd.name>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix sequence number assignment for PS response frames
Date: Mon, 12 Sep 2016 12:56:06 +0200 [thread overview]
Message-ID: <87sht5fku1.fsf@toke.dk> (raw)
In-Reply-To: <96ab269f-a40c-8824-1e61-fd17666ded46@nbd.name> (Felix Fietkau's message of "Mon, 12 Sep 2016 12:08:35 +0200")
Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org> writes:
> On 2016-09-12 12:07, Johannes Berg wrote:
>> On Mon, 2016-09-12 at 12:05 +0200, Felix Fietkau wrote:
>>> On 2016-09-12 12:03, Johannes Berg wrote:
>>> >
>>> >
>>> > >
>>> > > Hm, I guess I didn't think of that. I guess this potential issue
>>> > > will
>>> > > go away once we get Toke's tx handler reorder patch fixed,
>>> > > rebased
>>> > > and integrated.
>>> > >
>>> >
>>> > I don't really see how that helps?
>>> It replaces the changes that I made.
>>>
>>
>> But this is a more general problem, no?
> Will look into it some more soon.
>
> - Felix
Well, ath9k calls ieee80211_tx_dequeue while holding the (driver) TXQ
lock. Which means that a packet going through the old TX path can block
waiting for the driver to finish pulling packets from the mac80211
queue. So that could definitely lead to reordering of sequence numbers.
And the obvious fix of taking a lock in mac80211 could then lead to
deadlock. Fun times! :)
Hmm, is there a reason why those packets *have* to go through the old TX
path? My reordering patchset introduces a queue that takes priority over
the FQ (for fragments created after dequeue). Would sticking the PS
response frame on there and having the driver pull it work?
-Toke
prev parent reply other threads:[~2016-09-12 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 16:00 [PATCH] mac80211: fix sequence number assignment for PS response frames Felix Fietkau
2016-09-12 9:58 ` Johannes Berg
2016-09-12 10:01 ` Felix Fietkau
2016-09-12 10:03 ` Johannes Berg
2016-09-12 10:05 ` Felix Fietkau
2016-09-12 10:07 ` Johannes Berg
2016-09-12 10:08 ` Felix Fietkau
2016-09-12 10:56 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sht5fku1.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox