From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum
Date: Sat, 24 Sep 2016 10:43:07 -0700 [thread overview]
Message-ID: <1474738987.23838.13.camel@perches.com> (raw)
In-Reply-To: <1474736239-9826-3-git-send-email-Larry.Finger@lwfinger.net>
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote:
> The entries in this enum may be referenced in debug output. Adding explicit
> values simplifies the lookup.
A negative aspect to this style is forced renumbering
if a HW_VAR entry is inserted.
Is that possible?
next prev parent reply other threads:[~2016-09-24 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 16:57 [PATCH 0/2] rtlwifi: Add missing values to case statements and simplify debugging Larry Finger
2016-09-24 16:57 ` [PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines Larry Finger
2016-09-24 17:47 ` Joe Perches
2016-09-27 15:46 ` [1/2] " Kalle Valo
2016-09-24 16:57 ` [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum Larry Finger
2016-09-24 17:43 ` Joe Perches [this message]
2016-09-24 18:06 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474738987.23838.13.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox