From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines
Date: Sat, 24 Sep 2016 10:47:31 -0700 [thread overview]
Message-ID: <1474739251.23838.15.camel@perches.com> (raw)
In-Reply-To: <1474736239-9826-2-git-send-email-Larry.Finger@lwfinger.net>
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote:
> Only rtl8821ae implements WOWLAN; however, the other drivers may receive
> a call requesting information about this mode. The other drivers need to
> ignore the request rather than logging that the default branch of the
> switch statement has been reached.
How about later rationalizing the DBG_EMERG vs DBG_LOUD differences too?
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c
[]
> @@ -355,6 +355,8 @@ void rtl88ee_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
[]
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> "switch case %#x not processed\n", variable);
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
[]
> @@ -141,6 +141,8 @@ void rtl8723e_get_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
[]
> default:
> RT_TRACE(rtlpriv, COMP_ERR, DBG_LOUD,
> "switch case %#x not processed\n", variable);
etc...
next prev parent reply other threads:[~2016-09-24 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 16:57 [PATCH 0/2] rtlwifi: Add missing values to case statements and simplify debugging Larry Finger
2016-09-24 16:57 ` [PATCH 1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines Larry Finger
2016-09-24 17:47 ` Joe Perches [this message]
2016-09-27 15:46 ` [1/2] " Kalle Valo
2016-09-24 16:57 ` [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum Larry Finger
2016-09-24 17:43 ` Joe Perches
2016-09-24 18:06 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474739251.23838.15.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox