* [PATCH -next] cfg80211: fix possible memory leak in cfg80211_iter_combinations()
@ 2016-10-17 15:25 Wei Yongjun
2016-10-18 6:51 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-10-17 15:25 UTC (permalink / raw)
To: Johannes Berg, Purushottam Kushwaha; +Cc: Wei Yongjun, linux-wireless
From: Wei Yongjun <weiyongjun1@huawei.com>
'limits' is malloced in cfg80211_iter_combinations() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.
Fixes: 0c317a02ca98 ("cfg80211: support virtual interfaces with different
beacon intervals")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/wireless/util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index dd545ff..e36dbae 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -1672,8 +1672,10 @@ int cfg80211_iter_combinations(struct wiphy *wiphy,
if (params->beacon_int_gcd) {
if (c->beacon_int_min_gcd &&
- params->beacon_int_gcd < c->beacon_int_min_gcd)
+ params->beacon_int_gcd < c->beacon_int_min_gcd) {
+ kfree(limits);
return -EINVAL;
+ }
if (!c->beacon_int_min_gcd &&
params->beacon_int_different)
goto cont;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-18 6:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 15:25 [PATCH -next] cfg80211: fix possible memory leak in cfg80211_iter_combinations() Wei Yongjun
2016-10-18 6:51 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox