From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: cookie_counter in wiphy object
Date: Sat, 22 Oct 2016 22:26:26 +0200 [thread overview]
Message-ID: <1477167986.4123.1.camel@sipsolutions.net> (raw)
In-Reply-To: <0e3d457d-b0d1-f2b1-b18b-3f7b3e95365c@broadcom.com> (sfid-20161022_211311_238658_949F2131)
> Since commit a442b761b24b ("cfg80211: add add_nan_func /
> del_nan_func")
> there is a cookie_counter in the wiphy object. It is only used by the
> add_nan_func now, but do we want to consolidate all cookie returning
> functions to use this cookie counter, eg. in .remain_on_channel
> callback.
We probably could now. We used to use pointers and various other kinds
of crappy things for the cookies, but the counters are much safer,
reliable, and easier to debug. Naturally, it fell out that then the
cookies would be assigned in the drivers (well, mac80211), but here I
asked that be changed - I wouldn't mind changing it for other things as
well.
johannes
prev parent reply other threads:[~2016-10-22 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 19:13 cookie_counter in wiphy object Arend van Spriel
2016-10-22 20:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477167986.4123.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox