* cookie_counter in wiphy object
@ 2016-10-22 19:13 Arend van Spriel
2016-10-22 20:26 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Arend van Spriel @ 2016-10-22 19:13 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Hi Johannes,
Since commit a442b761b24b ("cfg80211: add add_nan_func / del_nan_func")
there is a cookie_counter in the wiphy object. It is only used by the
add_nan_func now, but do we want to consolidate all cookie returning
functions to use this cookie counter, eg. in .remain_on_channel callback.
Regards,
Arend
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: cookie_counter in wiphy object
2016-10-22 19:13 cookie_counter in wiphy object Arend van Spriel
@ 2016-10-22 20:26 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2016-10-22 20:26 UTC (permalink / raw)
To: Arend van Spriel; +Cc: linux-wireless
> Since commit a442b761b24b ("cfg80211: add add_nan_func /
> del_nan_func")
> there is a cookie_counter in the wiphy object. It is only used by the
> add_nan_func now, but do we want to consolidate all cookie returning
> functions to use this cookie counter, eg. in .remain_on_channel
> callback.
We probably could now. We used to use pointers and various other kinds
of crappy things for the cookies, but the counters are much safer,
reliable, and easier to debug. Naturally, it fell out that then the
cookies would be assigned in the drivers (well, mac80211), but here I
asked that be changed - I wouldn't mind changing it for other things as
well.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-22 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-22 19:13 cookie_counter in wiphy object Arend van Spriel
2016-10-22 20:26 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox