From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH 02/14] rtlwifi_new: Remove RT_TRACE messages that use DBG_EMERG
Date: Sun, 11 Dec 2016 02:50:45 -0800 [thread overview]
Message-ID: <1481453445.1764.11.camel@perches.com> (raw)
In-Reply-To: <20161211054523.7119-3-Larry.Finger@lwfinger.net>
On Sat, 2016-12-10 at 23:44 -0600, Larry Finger wrote:
> These messages are always logged and reprresent error conditions, thus
> we can use pr_err().
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 15 ++++-----
> drivers/net/wireless/realtek/rtlwifi/cam.c | 14 +++------
> drivers/net/wireless/realtek/rtlwifi/core.c | 21 +++++--------
> drivers/net/wireless/realtek/rtlwifi/debug.c | 9 ++----
> drivers/net/wireless/realtek/rtlwifi/debug.h | 2 +-
> drivers/net/wireless/realtek/rtlwifi/efuse.c | 3 +-
> drivers/net/wireless/realtek/rtlwifi/pci.c | 36 ++++++++--------------
> drivers/net/wireless/realtek/rtlwifi/ps.c | 3 +-
> drivers/net/wireless/realtek/rtlwifi/rc.c | 3 +-
> drivers/net/wireless/realtek/rtlwifi/usb.c | 46 +++++++++-------------------
> 10 files changed, 53 insertions(+), 99 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
[]
> @@ -207,8 +207,7 @@ static void _rtl_init_hw_ht_capab(struct ieee80211_hw *hw,
> *highest supported RX rate
> */
> if (rtlpriv->dm.supp_phymode_switch) {
> - RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
> - "Support phy mode switch\n");
> + pr_err("rtlwifi: Support phy mode switch\n");
I believe most all of these are already prefixed
by the wifi.h that has a #define pr_fmt
next prev parent reply other threads:[~2016-12-11 10:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 5:44 [PATCH 00/14] rtlwifi: Start reworking of debug system Larry Finger
2016-12-11 5:44 ` [PATCH 01/14] rtlwifi: Replace local debug macro RT_ASSERT Larry Finger
2016-12-11 5:44 ` [PATCH 02/14] rtlwifi_new: Remove RT_TRACE messages that use DBG_EMERG Larry Finger
2016-12-11 10:50 ` Joe Perches [this message]
2016-12-11 15:31 ` Larry Finger
2016-12-11 5:45 ` [PATCH 02/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 03/14] rtlwifi_new: rtl8821ae: Remove all instances of DBG_EMERG Larry Finger
2016-12-11 5:45 ` [PATCH 03/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 04/14] rtlwifi_new: rtl8723be: " Larry Finger
2016-12-11 5:45 ` [PATCH 04/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 05/14] rtlwifi_new: rtl8723ae: " Larry Finger
2016-12-11 5:45 ` [PATCH 05/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 06/14] rtlwifi_new: rtl8192ee: " Larry Finger
2016-12-11 5:45 ` [PATCH 06/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 07/14] rtlwifi_new: rtl8723-common: " Larry Finger
2016-12-11 5:45 ` [PATCH 07/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 08/14] rtlwifi_new: rtl8192se: " Larry Finger
2016-12-11 5:45 ` [PATCH 08/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 09/14] rtlwifi_new: rtl8192de: " Larry Finger
2016-12-11 5:45 ` [PATCH 09/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 10/14] rtlwifi_new: rtl8192cu: " Larry Finger
2016-12-11 5:45 ` [PATCH 10/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 11/14] rtlwifi_new: rtl8192ce: " Larry Finger
2016-12-11 5:45 ` [PATCH 11/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 12/14] rtlwifi_new: rtl8192c-common: " Larry Finger
2016-12-11 5:45 ` [PATCH 12/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 13/14] rtlwifi_new: rtl8188ee: " Larry Finger
2016-12-11 5:45 ` [PATCH 13/14] rtlwifi: " Larry Finger
2016-12-11 5:45 ` [PATCH 14/14] rtlwifi: Remove some redundant code Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481453445.1764.11.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox