Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org
Cc: "Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Felix Fietkau" <nbd@nbd.name>,
	"Arend van Spriel" <arend@broadcom.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	devicetree@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3 2/2] cfg80211: support ieee80211-freq-limit DT property
Date: Tue, 03 Jan 2017 08:00:58 +0100	[thread overview]
Message-ID: <1483426858.15591.3.camel@sipsolutions.net> (raw)
In-Reply-To: <e194b980-1048-8da6-624b-26f824ff655d@broadcom.com> (sfid-20170102_211210_491488_1DB64A4C)


> I suppose this then can also be done early in the wiphy_register()
> function itself, right?

No, because of the shared channel data issue. If this is
unconditionally in wiphy_register() then we can no longer guarantee
that sharing it is acceptable - which it is today under certain
circumstances the driver controls. This would move it out of driver
control, making it never possible to share any more.

> So does it mean the function can go in core.c again :-p If it is
> likely there will be other properties being added it might justify
> adding a new source file, eg. of.c, and only compile it when
> CONFIG_OF is set. Just a thought.

Yeah, whatever :)
We can figure that out once we have the mechanisms in place.

johannes

  parent reply	other threads:[~2017-01-03  7:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 16:32 [PATCH V3 1/2] dt-bindings: document common IEEE 802.11 frequency limit property Rafał Miłecki
2017-01-02 16:32 ` [PATCH V3 2/2] cfg80211: support ieee80211-freq-limit DT property Rafał Miłecki
2017-01-02 17:52   ` Johannes Berg
2017-01-02 20:12     ` Arend van Spriel
2017-01-02 22:16       ` Rafał Miłecki
2017-01-03  7:00       ` Johannes Berg [this message]
2017-01-02 22:12     ` Rafał Miłecki
2017-01-03  7:06       ` Johannes Berg
2017-01-02 16:32 ` [PATCH V3 3/2] brcmfmac: use wiphy_read_of_freq_limits to get extra limits Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483426858.15591.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=arend@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=nbd@nbd.name \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox