* [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement
@ 2017-03-02 16:14 Georgios Emmanouil
2017-03-04 22:47 ` Julian Calaby
0 siblings, 1 reply; 2+ messages in thread
From: Georgios Emmanouil @ 2017-03-02 16:14 UTC (permalink / raw)
To: aditya.shankar, ganesh.krishna, gregkh
Cc: linux-wireless, devel, linux-kernel
Modified the 'if-else' statement to make it more readable.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 2eebc62..d82f0ff 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -867,15 +867,10 @@ static int wilc_mac_open(struct net_device *ndev)
wilc_get_vif_idx(vif),
wl->open_ifcs);
} else {
- if (memcmp(wl->vif[i ^ 1]->bssid,
- wl->vif[i ^ 1]->src_addr, 6))
- wilc_set_wfi_drv_handler(vif,
- wilc_get_vif_idx(vif),
- 0);
+ if (memcmp(wl->vif[i ^ 1]->bssid, wl->vif[i ^ 1]->src_addr, 6))
+ wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 0);
else
- wilc_set_wfi_drv_handler(vif,
- wilc_get_vif_idx(vif),
- 1);
+ wilc_set_wfi_drv_handler(vif, wilc_get_vif_idx(vif), 1);
}
wilc_set_operation_mode(vif, vif->iftype);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement
2017-03-02 16:14 [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement Georgios Emmanouil
@ 2017-03-04 22:47 ` Julian Calaby
0 siblings, 0 replies; 2+ messages in thread
From: Julian Calaby @ 2017-03-04 22:47 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: Aditya Shankar, Ganesh Krishna, Greg KH, linux-wireless,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Hi All,
On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <geo.emmnl@gmail.com> wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
Again, I'm dubious if this is needed or helpful, but
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> ---
> drivers/staging/wilc1000/linux_wlan.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-04 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-02 16:14 [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement Georgios Emmanouil
2017-03-04 22:47 ` Julian Calaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox