From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: [PATCH 07/10] brcmfmac: remove unnecessary call to brcmf_sdiod_set_backplane_window()
Date: Fri, 8 Dec 2017 13:10:32 +0100 [thread overview]
Message-ID: <1512735035-342-8-git-send-email-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <1512735035-342-1-git-send-email-arend.vanspriel@broadcom.com>
From: Ian Molton <ian@mnementh.co.uk>
All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.
Signed-off-by: Ian Molton <ian@mnementh.co.uk>
[arend: corrected the driver prefix in the subject]
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index 5fcd193..f8b47c1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -723,11 +723,6 @@ int brcmf_sdiod_send_pkt(struct brcmf_sdio_dev *sdiodev,
dev_kfree_skb(pkt);
- /* Return the window to backplane enumeration space for core access */
- if (brcmf_sdiod_set_backplane_window(sdiodev, sdiodev->sbwad))
- brcmf_err("FAILED to set window back to 0x%x\n",
- sdiodev->sbwad);
-
sdio_release_host(sdiodev->func[1]);
return err;
--
1.9.1
next prev parent reply other threads:[~2017-12-08 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 12:10 [PATCH 00/10] brcmfmac: restructuring sdio access functions - take 2 Arend van Spriel
2017-12-08 12:10 ` [PATCH 01/10] brcmfmac: Split brcmf_sdiod_buffrw function up Arend van Spriel
2017-12-14 12:41 ` [01/10] " Kalle Valo
2017-12-08 12:10 ` [PATCH 02/10] brcmfmac: whitespace fixes in brcmf_sdiod_send_buf() Arend van Spriel
2017-12-08 12:10 ` [PATCH 03/10] brcmfmac: Clarify if using braces Arend van Spriel
2017-12-08 12:10 ` [PATCH 04/10] brcmfmac: Rename / replace old IO functions with simpler ones Arend van Spriel
2017-12-08 12:10 ` [PATCH 05/10] brcmfmac: Tidy register definitions a little Arend van Spriel
2017-12-08 12:10 ` [PATCH 06/10] brcmfmac: Remove brcmf_sdiod_addrprep() Arend van Spriel
2017-12-08 12:10 ` Arend van Spriel [this message]
2017-12-08 12:10 ` [PATCH 08/10] brcmfmac: Cleanup offsetof() Arend van Spriel
2017-12-08 12:10 ` [PATCH 09/10] brcmfmac: Remove unused macro Arend van Spriel
2017-12-08 12:10 ` [PATCH 10/10] brcmfmac: Remove repeated calls to brcmf_chip_get_core() Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512735035-342-8-git-send-email-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=ian@mnementh.co.uk \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox