From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-wireless@vger.kernel.org, nbd@nbd.name, sara.sharon@intel.com
Subject: Re: [PATCH v2] mac80211: do not aggregate frames if max_frags is set to one
Date: Wed, 29 Aug 2018 21:05:48 +0200 [thread overview]
Message-ID: <1535569548.5215.33.camel@sipsolutions.net> (raw)
In-Reply-To: <d016cad18842b71c6f06710cbc71cb3d55466a2e.1535567864.git.lorenzo.bianconi@redhat.com> (sfid-20180829_210349_105825_7C40E092)
On Wed, 2018-08-29 at 21:03 +0200, Lorenzo Bianconi wrote:
> Do not try to aggregate packets in a A-MSDU frame and add A-MSDU header
> on the first packet if max_tx_fragments or max_amsdu_subframes are
> set to one
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
> Changes since v1:
> - rebased on top of mac80211 master branch
> - removed ieee80211_amsdu_realloc_pad chunk
>
Don't you still have to account for the changed header length if the
second one fails or something?
You said you wanted to account for the pad bytes - which now aren't
there - but didn't that also take the changed header of the first
subframe into account?
johannes
next prev parent reply other threads:[~2018-08-29 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1535567864.git.lorenzo.bianconi@redhat.com>
2018-08-29 19:03 ` [PATCH v2] mac80211: do not aggregate frames if max_frags is set to one Lorenzo Bianconi
2018-08-29 19:05 ` Johannes Berg [this message]
2018-08-29 19:12 ` Lorenzo Bianconi
[not found] ` <1535570007.5215.34.camel@sipsolutions.net>
2018-08-29 19:30 ` Lorenzo Bianconi
2018-08-30 8:03 ` Johannes Berg
2018-08-30 8:31 ` Lorenzo Bianconi
2018-08-30 8:39 ` Johannes Berg
2018-08-30 8:50 ` Lorenzo Bianconi
2018-08-30 8:53 ` Johannes Berg
2018-08-30 9:00 ` Lorenzo Bianconi
2018-08-30 9:03 ` Johannes Berg
2018-08-30 9:06 ` Johannes Berg
2018-08-30 9:07 ` Lorenzo Bianconi
2018-08-30 9:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535569548.5215.33.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox