From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: do not aggregate frames if max_frags is set to one
Date: Thu, 30 Aug 2018 10:53:09 +0200 [thread overview]
Message-ID: <1535619189.5215.47.camel@sipsolutions.net> (raw)
In-Reply-To: <20180830085054.GB9867@localhost.localdomain> (sfid-20180830_105058_442284_40CB73B8)
On Thu, 2018-08-30 at 10:50 +0200, Lorenzo Bianconi wrote:
>
> ack, I agree. Do you want I send a patch to fix it?
I have it written now, I'll just commit & send it out.
> > Hmm, not sure I follow? "head" is the A-MSDU, containing the A-MSDU
> > header and the first subframe in skb->data (and/or frags), with the
> > subframes 2..N in the fraglist.
> >
> > So I think this is right?
>
> yep, correct. But when we are analyzing the second subframe what is the correct value for 'n'?
> 1 or 2? At the moment I guess it is set to 1 if frag_tail is NULL for head.
Ah. I guess you're right. So basically setting max_subframes to 1
doesn't avoid A-MSDUs completely, since n will still be 1 when we get
here ... good point, care to send a patch?
johannes
next prev parent reply other threads:[~2018-08-30 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1535567864.git.lorenzo.bianconi@redhat.com>
2018-08-29 19:03 ` [PATCH v2] mac80211: do not aggregate frames if max_frags is set to one Lorenzo Bianconi
2018-08-29 19:05 ` Johannes Berg
2018-08-29 19:12 ` Lorenzo Bianconi
[not found] ` <1535570007.5215.34.camel@sipsolutions.net>
2018-08-29 19:30 ` Lorenzo Bianconi
2018-08-30 8:03 ` Johannes Berg
2018-08-30 8:31 ` Lorenzo Bianconi
2018-08-30 8:39 ` Johannes Berg
2018-08-30 8:50 ` Lorenzo Bianconi
2018-08-30 8:53 ` Johannes Berg [this message]
2018-08-30 9:00 ` Lorenzo Bianconi
2018-08-30 9:03 ` Johannes Berg
2018-08-30 9:06 ` Johannes Berg
2018-08-30 9:07 ` Lorenzo Bianconi
2018-08-30 9:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535619189.5215.47.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox