Linux wireless drivers development
 help / color / mirror / Atom feed
From: Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "brcm80211-dev-list@broadcom.com"
	<brcm80211-dev-list@broadcom.com>,
	brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Wright Feng <Wright.Feng@cypress.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Double Lo <Double.Lo@cypress.com>,
	Madhan Mohan R <MadhanMohan.R@cypress.com>,
	Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Subject: [PATCH V2 8/8] brcmfmac: disable command decode in sdio_aos
Date: Mon, 12 Nov 2018 07:30:01 +0000	[thread overview]
Message-ID: <1542007730-47284-9-git-send-email-chi-hsien.lin@cypress.com> (raw)
In-Reply-To: <1542007730-47284-1-git-send-email-chi-hsien.lin@cypress.com>

From: Wright Feng <wright.feng@cypress.com>

AOS is a part of the SDIOD core that becomes active when the rest of
SDIOD is sleeping to keep SDIO bus alive responding to reduced set of
commands.

Transaction between AOS and SDIOD is not protected, and if cmd 52 is
received in AOS and in the middle of response state changed from AOS to
SDIOD, response is corrupted and it causes to SDIO Host controller to
hang.

Command decode for below chips are disabled in this commit:
 - 4339
 - 4345
 - 4354
 - 4373

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Wright Feng <wright.feng@cypress.com>
Signed-off-by: Double Lo <double.lo@cypress.com>
Signed-off-by: Madhan Mohan R <madhanmohan.r@cypress.com>
Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index e1708e297d07..e5f487b37c5a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -3354,7 +3354,11 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus,
 
 static bool brcmf_sdio_aos_no_decode(struct brcmf_sdio *bus)
 {
-	if (bus->ci->chip == CY_CC_43012_CHIP_ID)
+	if (bus->ci->chip == CY_CC_43012_CHIP_ID ||
+	    bus->ci->chip == CY_CC_4373_CHIP_ID ||
+	    bus->ci->chip == BRCM_CC_4339_CHIP_ID ||
+	    bus->ci->chip == BRCM_CC_4345_CHIP_ID ||
+	    bus->ci->chip == BRCM_CC_4354_CHIP_ID)
 		return true;
 	else
 		return false;
-- 
2.1.0


  parent reply	other threads:[~2018-11-12  7:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  7:29 [PATCH V2 0/8] brcmfmac: chip related changes Chi-Hsien Lin
2018-11-12  7:29 ` [PATCH V2 1/8] brcmfmac: add 4354 raw pcie device id Chi-Hsien Lin
2018-11-12 10:11   ` Arend van Spriel
2018-11-12  7:29 ` [PATCH V2 2/8] brcmfmac: set F2 watermark to 256 for 4373 Chi-Hsien Lin
2018-11-12 10:12   ` Arend van Spriel
2018-11-12  7:29 ` [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373 Chi-Hsien Lin
2018-11-12  9:13   ` Arend van Spriel
2018-11-20  8:50     ` Madhan Mohan R
2018-11-20  9:53       ` Arend van Spriel
2018-11-12  7:29 ` [PATCH V2 4/8] brcmfmac: add support for CYW43012 SDIO chipset Chi-Hsien Lin
2018-11-12  7:29 ` [PATCH V2 5/8] brcmfmac: allow GCI core enumuration Chi-Hsien Lin
2018-11-12 10:16   ` Arend van Spriel
2018-11-12 10:24     ` Chi-Hsien Lin
2018-11-12 10:27       ` Arend van Spriel
2018-11-12 10:29         ` Chi-Hsien Lin
2018-11-12  7:29 ` [PATCH V2 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic Chi-Hsien Lin
2018-11-12  9:25   ` Arend van Spriel
2018-11-20  9:13     ` Chi-Hsien Lin
2018-11-12  7:29 ` [PATCH V2 7/8] brcmfmac: 4373 save-restore support Chi-Hsien Lin
2018-11-12 10:30   ` Arend van Spriel
2018-11-20  9:15     ` Chi-Hsien Lin
2018-11-12  7:30 ` Chi-Hsien Lin [this message]
2018-11-12 10:31   ` [PATCH V2 8/8] brcmfmac: disable command decode in sdio_aos Arend van Spriel
2018-11-12 10:33   ` Arend van Spriel
2018-11-15  8:08     ` Wright Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542007730-47284-9-git-send-email-chi-hsien.lin@cypress.com \
    --to=chi-hsien.lin@cypress.com \
    --cc=Double.Lo@cypress.com \
    --cc=MadhanMohan.R@cypress.com \
    --cc=Wright.Feng@cypress.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox