From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Madhan Mohan R <MadhanMohan.R@cypress.com>
Cc: Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <Wright.Feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373
Date: Tue, 20 Nov 2018 10:53:32 +0100 [thread overview]
Message-ID: <4cfaa1cc-2561-6c8d-18b1-4f5a61790cfe@broadcom.com> (raw)
In-Reply-To: <20181120085049.GB1563@aremote02.aus.cypress.com>
On 11/20/2018 9:50 AM, Madhan Mohan R wrote:
> On Mon, Nov 12, 2018 at 10:13:07AM +0100, Arend van Spriel wrote:
>> On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote:
>>> From: Madhan Mohan R <MadhanMohan.R@cypress.com>
>>>
>>> Along with F2 watermark (existing) configuration, F1 MesBusyCtrl
>>> should be enabled & configured to avoid overflow errors.
>>
>> I am a bit confused. Why is it necessary to program the watermark in
>> both SBSDIO_WATERMARK (0x10008) and SDSDIO_FUNC1_MESBUSYCTRL
>> (0x1001D).
>> Looks suspicious to me.
>>
>> Regards,
>> Arend
>
> Hi Arend,
>
> Register SDSDIO_FUNC1_MESBUSYCTRL(0x1001D) Bits [6:0] is programmed with
> SDIO RX path watermark whereas the register SBSDIO_WATERMARK(0x10008) is
> for the SDIO TX path.
Thanks, Madhan
That makes sense. Maybe it would be good to express the tx vs rx detail
in the code.
Regards,
Arend
next prev parent reply other threads:[~2018-11-20 9:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 7:29 [PATCH V2 0/8] brcmfmac: chip related changes Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 1/8] brcmfmac: add 4354 raw pcie device id Chi-Hsien Lin
2018-11-12 10:11 ` Arend van Spriel
2018-11-12 7:29 ` [PATCH V2 2/8] brcmfmac: set F2 watermark to 256 for 4373 Chi-Hsien Lin
2018-11-12 10:12 ` Arend van Spriel
2018-11-12 7:29 ` [PATCH V2 3/8] brcmfmac: set SDIO F1 MesBusyCtrl for CYW4373 Chi-Hsien Lin
2018-11-12 9:13 ` Arend van Spriel
2018-11-20 8:50 ` Madhan Mohan R
2018-11-20 9:53 ` Arend van Spriel [this message]
2018-11-12 7:29 ` [PATCH V2 4/8] brcmfmac: add support for CYW43012 SDIO chipset Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 5/8] brcmfmac: allow GCI core enumuration Chi-Hsien Lin
2018-11-12 10:16 ` Arend van Spriel
2018-11-12 10:24 ` Chi-Hsien Lin
2018-11-12 10:27 ` Arend van Spriel
2018-11-12 10:29 ` Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 6/8] brcmfmac: update 43012 F2 watermark setting to fix DMA Error during UDP RX Traffic Chi-Hsien Lin
2018-11-12 9:25 ` Arend van Spriel
2018-11-20 9:13 ` Chi-Hsien Lin
2018-11-12 7:29 ` [PATCH V2 7/8] brcmfmac: 4373 save-restore support Chi-Hsien Lin
2018-11-12 10:30 ` Arend van Spriel
2018-11-20 9:15 ` Chi-Hsien Lin
2018-11-12 7:30 ` [PATCH V2 8/8] brcmfmac: disable command decode in sdio_aos Chi-Hsien Lin
2018-11-12 10:31 ` Arend van Spriel
2018-11-12 10:33 ` Arend van Spriel
2018-11-15 8:08 ` Wright Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cfaa1cc-2561-6c8d-18b1-4f5a61790cfe@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=MadhanMohan.R@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox