From: Kalle Valo <kvalo@kernel.org>
To: Niels Dossche <dossche.niels@gmail.com>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Carl Huang <cjhuang@codeaurora.org>,
Niels Dossche <dossche.niels@gmail.com>
Subject: Re: [PATCH] ath11k: acquire ab->base_lock in unassign when finding the peer by addr
Date: Wed, 23 Mar 2022 08:52:30 +0000 (UTC) [thread overview]
Message-ID: <164802554371.545.14175354051813428443.kvalo@kernel.org> (raw)
In-Reply-To: <20220314215253.92658-1-dossche.niels@gmail.com>
Niels Dossche <dossche.niels@gmail.com> wrote:
> ath11k_peer_find_by_addr states via lockdep that ab->base_lock must be
> held when calling that function in order to protect the list. All
> callers except ath11k_mac_op_unassign_vif_chanctx have that lock
> acquired when calling ath11k_peer_find_by_addr. That lock is also not
> transitively held by a path towards ath11k_mac_op_unassign_vif_chanctx.
> The solution is to acquire the lock when calling
> ath11k_peer_find_by_addr inside ath11k_mac_op_unassign_vif_chanctx.
>
> I am currently working on a static analyser to detect missing locks and
> this was a reported case. I manually verified the report by looking at
> the code, but I do not have real hardware so this is compile tested
> only.
>
> Fixes: 701e48a43e15 ("ath11k: add packet log support for QCA6390")
> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2db80f93869d ath11k: acquire ab->base_lock in unassign when finding the peer by addr
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220314215253.92658-1-dossche.niels@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-03-23 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:52 [PATCH] ath11k: acquire ab->base_lock in unassign when finding the peer by addr Niels Dossche
2022-03-16 6:13 ` Kalle Valo
2022-03-16 10:43 ` Niels Dossche
2022-03-16 14:34 ` Kalle Valo
2022-03-16 14:38 ` Niels Dossche
2022-03-21 10:45 ` Kalle Valo
2022-03-21 11:51 ` Niels Dossche
2022-03-23 8:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164802554371.545.14175354051813428443.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dossche.niels@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox