From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: <duoming@zju.edu.cn>, Kalle Valo <kvalo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <amitkarwar@gmail.com>,
<ganapathi017@gmail.com>, <sharvari.harisangam@nxp.com>,
<huxinming820@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net v2] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs
Date: Thu, 19 May 2022 08:48:44 -0700 [thread overview]
Message-ID: <18852332-ee42-ef7e-67a3-bbd91a6694ba@quicinc.com> (raw)
In-Reply-To: <699e56d5.22006.180dce26e02.Coremail.duoming@zju.edu.cn>
On 5/19/2022 8:14 AM, duoming@zju.edu.cn wrote:
> Hello,
>
> On Thu, 19 May 2022 17:58:47 +0300 Kalle Valo wrote:
>
>>> There are sleep in atomic context bugs when uploading device dump
>>> data on usb interface. The root cause is that the operations that
>>> may sleep are called in fw_dump_timer_fn which is a timer handler.
>>> The call tree shows the execution paths that could lead to bugs:
>>>
>>> (Interrupt context)
>>> fw_dump_timer_fn
>>> mwifiex_upload_device_dump
>>> dev_coredumpv(..., GFP_KERNEL)
just looking at this description, why isn't the simple fix just to
change this call to use GFP_ATOMIC?
next prev parent reply other threads:[~2022-05-19 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 13:53 [PATCH net v2] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs Duoming Zhou
2022-05-19 14:58 ` Kalle Valo
2022-05-19 15:14 ` duoming
2022-05-19 15:48 ` Jeff Johnson [this message]
2022-05-20 0:08 ` duoming
2022-05-20 16:08 ` Jeff Johnson
2022-05-21 3:21 ` duoming
2022-05-21 6:32 ` Kalle Valo
2022-05-21 13:59 ` duoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18852332-ee42-ef7e-67a3-bbd91a6694ba@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharvari.harisangam@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox