Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marcel Holtmann <marcel@holtmann.org>, Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: add local BSS receive time to survey information
Date: Wed, 28 Aug 2019 21:44:22 +0200	[thread overview]
Message-ID: <18c4232675c7b4f13fbfe9e5d8e9364a0908f316.camel@sipsolutions.net> (raw)
In-Reply-To: <9189B2C1-6E5B-4457-9354-A010F946EE33@holtmann.org>

Hi Marcel,

> ... [snip]

Please trim quotes a bit.

> > 	NL80211_SURVEY_INFO_PAD,
> > +	NL80211_SURVEY_INFO_TIME_BSS_RX,
> 
> wouldn’t this go before the PAD attribute?

No, as usual, that would break ABI. PAD is a regular attribute, just
empty and ignored for aligning 64-bit values.

johannes


  reply	other threads:[~2019-08-28 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 10:20 [PATCH v2] cfg80211: add local BSS receive time to survey information Felix Fietkau
2019-08-28 17:25 ` Marcel Holtmann
2019-08-28 19:44   ` Johannes Berg [this message]
2019-08-28 19:52     ` Marcel Holtmann
2019-08-28 19:59       ` Johannes Berg
2019-08-28 20:24         ` Marcel Holtmann
2019-08-28 20:28           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18c4232675c7b4f13fbfe9e5d8e9364a0908f316.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox