Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH 3/6] ath9k: Stop ANI when doing a reset
@ 2009-12-14  9:32 Sujith
  2009-12-14 10:17 ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Sujith @ 2009-12-14  9:32 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless

The MIB counters are disabled when doing a reset,
disable ANI to handle this case.

Cc: stable@kernel.org
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
---
 drivers/net/wireless/ath/ath9k/main.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index c487434..9e68c1a 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1973,6 +1973,9 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
 	struct ieee80211_hw *hw = sc->hw;
 	int r;
 
+	/* Stop ANI */
+	del_timer_sync(&common->ani.timer);
+
 	ath9k_hw_set_interrupts(ah, 0);
 	ath_drain_all_txq(sc, retry_tx);
 	ath_stoprecv(sc);
@@ -2014,6 +2017,9 @@ int ath_reset(struct ath_softc *sc, bool retry_tx)
 		}
 	}
 
+	/* Start ANI */
+	ath_start_ani(common);
+
 	return r;
 }
 
-- 
1.6.5.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/6] ath9k: Stop ANI when doing a reset
  2009-12-14  9:32 [PATCH 3/6] ath9k: Stop ANI when doing a reset Sujith
@ 2009-12-14 10:17 ` Kalle Valo
  2009-12-14 11:04   ` Sujith
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2009-12-14 10:17 UTC (permalink / raw)
  To: Sujith; +Cc: linville, linux-wireless

Sujith <Sujith.Manoharan@atheros.com> writes:

> The MIB counters are disabled when doing a reset,
> disable ANI to handle this case.

The visible change to the user is good to explain. Was there packet
loss, did the kernel crash or what?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/6] ath9k: Stop ANI when doing a reset
  2009-12-14 10:17 ` Kalle Valo
@ 2009-12-14 11:04   ` Sujith
  0 siblings, 0 replies; 3+ messages in thread
From: Sujith @ 2009-12-14 11:04 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org

Kalle Valo wrote:
> The visible change to the user is good to explain. Was there packet
> loss, did the kernel crash or what?

Sub-optimal performance would be the visible impact.

Updated patch will follow momentarily.
Thanks for the review.

Sujith

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-12-14 11:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-14  9:32 [PATCH 3/6] ath9k: Stop ANI when doing a reset Sujith
2009-12-14 10:17 ` Kalle Valo
2009-12-14 11:04   ` Sujith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox