From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
"John W . Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] wireless: Driver for 60GHz card wil6210
Date: Wed, 31 Oct 2012 17:00:03 +0200 [thread overview]
Message-ID: <1952560.nYyRnDKWFr@lx-vladimir> (raw)
In-Reply-To: <1351693661.10946.0.camel@jlt4.sipsolutions.net>
On Wednesday, October 31, 2012 03:27:41 PM Johannes Berg wrote:
> On Wed, 2012-10-31 at 14:57 +0200, Vladimir Kondratiev wrote:
> > > You didn't also address my comments regarding WIL6210_ISR_COR #ifdef
> > > code.
> >
> > I added string with short explanation in Kconfig.
> > Longer explanation: while clear-on-read is good for production mode, it
> > makes debugging much harder - reading ISR registers clears interrupt, and
> > one can no more monitor ISR with debugfs. So, when debugging ISR flows -
> > and they still need some debugging - one have to use W1C mode. That's why
> > it is still present.
>
> Since I'm CC'ed on your patches (not sure why) I'll offer the opinion
> that you should add interrupt and IO access tracing rather than reading
> registers with some debug thing ;)
Johannes,
you just proved reason to be CC'ed: you give valuable feedback :-)
Oh, no! Usually, you start digging into ISR registers when something stalled
when it should not. At this point, you want to discover that, for example,
some interrupt bit not came up. Then, you may try to manually set it writing
into register. If you trace, it will flood dmesg, impacting performance, in
normal situation; and will not let you analyze and recover from abnormal one.
I need "manual control" here.
>
> johannes
next prev parent reply other threads:[~2012-10-31 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 11:58 [PATCH v2 0/2] driver for 60g Wilocity chip wil6210 Vladimir Kondratiev
2012-10-29 11:58 ` [PATCH v2 1/2] wireless: Driver for 60GHz card wil6210 Vladimir Kondratiev
2012-10-31 1:23 ` Luis R. Rodriguez
2012-10-31 12:57 ` Vladimir Kondratiev
2012-10-31 13:03 ` Luis R. Rodriguez
2012-10-31 14:27 ` Johannes Berg
2012-10-31 15:00 ` Vladimir Kondratiev [this message]
2012-10-31 15:04 ` Johannes Berg
2012-10-31 15:14 ` Luis R. Rodriguez
2012-10-31 17:25 ` Christian Lamparter
2012-10-31 18:53 ` Luis R. Rodriguez
2012-10-31 14:29 ` Gábor Stefanik
2012-10-31 14:52 ` Vladimir Kondratiev
2012-10-29 11:58 ` [PATCH v2 2/2] wireless: integrate wil6210 driver into build structure Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952560.nYyRnDKWFr@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox