From: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: "John W . Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>,
"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH v2 1/2] wireless: Driver for 60GHz card wil6210
Date: Tue, 30 Oct 2012 18:23:37 -0700 [thread overview]
Message-ID: <20121031012225.GY3354@lenteja.do-not-panic.com> (raw)
In-Reply-To: <1351511906-19989-2-git-send-email-qca_vkondrat@qca.qualcomm.com>
On Mon, Oct 29, 2012 at 01:58:25PM +0200, Vladimir Kondratiev wrote:
> Card wil6210 by Wilocity supports operation on the 60GHz band
>
> See
> http://wireless.kernel.org/en/users/Drivers/wil6210
Can you update that page to reflect the latest information?
Its out of date now.
> diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> new file mode 100644
> index 0000000..d2b14fb
> --- /dev/null
> +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> +static int wil_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> +{
> + { /* print various info */
> + struct net_device *ndev = wil_to_ndev(wil);
> + const char *pdev_name = pci_name(pdev);
> + const char *wiphydev_name = dev_name(wil_to_dev(wil));
> + const char *ndev_name = netdev_name(ndev);
> + const char *ifc_name = ndev->name;
> + struct pci_driver *drv = pci_dev_driver(pdev);
> + const char *drv_name = drv ? drv->name : "(no drv)";
> + pr_info("Driver : <%s>\n", drv_name ?: "(null)");
> + pr_info("PCI dev : <%s>\n", pdev_name ?: "(null)");
> + pr_info("Net dev : <%s>\n", ndev_name ?: "(null)");
> + pr_info("Net ifc : <%s>\n", ifc_name ?: "(null)");
> + pr_info("Wiphy : <%s>\n", wiphydev_name ?: "(null)");
> +
> + }
Die nasty code, die! Bleed!
> diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
> new file mode 100644
> index 0000000..463c68e
> --- /dev/null
> +++ b/drivers/net/wireless/ath/wil6210/txrx.c
> +void tx_complete(struct wil6210_priv *wil, int ringid)
> +{
...
> + {
> + u32 swhead = vring->swhead;
> + u32 swtail = vring->swtail;
> + int used = (vring->size + swhead - swtail) % vring->size;
> + int avail = vring->size - used - 1;
> + if (avail > vring->size/4)
> + netif_tx_wake_all_queues(wil_to_ndev(wil));
> + }
> +}
Die!
> diff --git a/drivers/net/wireless/ath/wil6210/wil6210.h b/drivers/net/wireless/ath/wil6210/wil6210.h
> new file mode 100644
> index 0000000..529b790
> --- /dev/null
> +++ b/drivers/net/wireless/ath/wil6210/wil6210.h
> @@ -0,0 +1,299 @@
...
> +#define WIL6210_DRV_VERSION "0.4" /* Driver version */
Again, death to this. I don't care what other drivers do, this
is silly practice.
You also still use generic routine names, please clean those
up. Few examples: tx_complete() rx_handle(), iftype_nl2wmi(),
and I'm sure there are plenty others, please prefix
these for the driver.
> diff --git a/drivers/net/wireless/ath/wil6210/wil6210_rgf.h b/drivers/net/wireless/ath/wil6210/wil6210_rgf.h
Any reason why this small file is required? Why not just stuff it into
one of the other header files?
You didn't also address my comments regarding WIL6210_ISR_COR #ifdef code.
The second patch no longer applies as a new driver was merged.
Apart from all this, looks good.
Luis
next prev parent reply other threads:[~2012-10-31 1:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 11:58 [PATCH v2 0/2] driver for 60g Wilocity chip wil6210 Vladimir Kondratiev
2012-10-29 11:58 ` [PATCH v2 1/2] wireless: Driver for 60GHz card wil6210 Vladimir Kondratiev
2012-10-31 1:23 ` Luis R. Rodriguez [this message]
2012-10-31 12:57 ` Vladimir Kondratiev
2012-10-31 13:03 ` Luis R. Rodriguez
2012-10-31 14:27 ` Johannes Berg
2012-10-31 15:00 ` Vladimir Kondratiev
2012-10-31 15:04 ` Johannes Berg
2012-10-31 15:14 ` Luis R. Rodriguez
2012-10-31 17:25 ` Christian Lamparter
2012-10-31 18:53 ` Luis R. Rodriguez
2012-10-31 14:29 ` Gábor Stefanik
2012-10-31 14:52 ` Vladimir Kondratiev
2012-10-29 11:58 ` [PATCH v2 2/2] wireless: integrate wil6210 driver into build structure Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031012225.GY3354@lenteja.do-not-panic.com \
--to=rodrigue@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox