Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "mohamed salim abbas" <mabbaswireless@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"Michael Wu" <flamingice@sourmilk.net>
Subject: Re: A-MSDU deaggregation support
Date: Mon, 10 Sep 2007 14:41:46 +0300	[thread overview]
Message-ID: <1ba2fa240709100441o421653fbre410df615e7d9e10@mail.gmail.com> (raw)
In-Reply-To: <1189354526.4506.25.camel@johannes.berg>

On 9/9/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> Hey,
>
> I just looked at the deaggregation code for unrelated reasons and
> thought about it a bit more; shouldn't there be some sort of checks that
> the 802.11 rules about identical addresses are adhered to to avoid
> having rogue packets pretending to come from somewhere else enter the
> networking stack? This can usually be avoided by using RSNA, but this
> code allows one to easily circumvent this which makes us look pretty
> bad.
>
> Makes you wonder why they included full 802.3 framing in the
> subframes...
>
There is difference between receiving and destination address. AP is
receiving address but not the destination. If station sends packets to
multiple stations it still go through one AP (receiving address). The
only restriction is that all the packets in A-MSDU belongs to one TID
stream.

There is actually different problem with the A-MSDU deaggregation and
this is EPOL filtering. One of the packets might belong to EAPOL
handshake

Tomas

> johannes
>
>

  reply	other threads:[~2007-09-10 11:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-09 16:15 A-MSDU deaggregation support Johannes Berg
2007-09-10 11:41 ` Tomas Winkler [this message]
2007-09-10 11:49   ` Johannes Berg
2007-09-25 19:19   ` Johannes Berg
2007-09-25 23:24     ` Tomas Winkler
2007-09-26  7:39       ` Johannes Berg
2007-09-26 11:46         ` Tomas Winkler
2007-09-26 12:16           ` Johannes Berg
2007-09-26 12:32             ` Tomas Winkler
2007-09-26 12:37               ` Johannes Berg
2007-09-28  1:39         ` Jouni Malinen
2007-09-28  8:34           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba2fa240709100441o421653fbre410df615e7d9e10@mail.gmail.com \
    --to=tomasw@gmail.com \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mabbaswireless@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox