Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "mohamed salim abbas" <mabbaswireless@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"Michael Wu" <flamingice@sourmilk.net>, "Jouni Malinen" <j@w1.fi>
Subject: Re: A-MSDU deaggregation support
Date: Wed, 26 Sep 2007 13:46:05 +0200	[thread overview]
Message-ID: <1ba2fa240709260446u2facb62fw1a17af1665b25d03@mail.gmail.com> (raw)
In-Reply-To: <1190792394.18521.354.camel@johannes.berg>

On 9/26/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Wed, 2007-09-26 at 01:24 +0200, Tomas Winkler wrote:
>
> > EAPOL frames should not be filtered out. Everything else should be filtered out
> > except EAPOL frames till the port is open.
>
> Right now though, when we're an AP, we're sending EAPOL frames to the
> mgmt interface instead of the regular 802.3 interface. This quite sucks
> wrt. deagg. But it's also very weird, look at ieee80211_rx_h_802_1x_pae.
> It sends
>  * eapol frames for non-STA interfaces that are for us -> mgmt iface
>  * non-eapol frames from unauthorized STAs -> bitbucket
>  * everything else -> the regular 802.3 interface
>
> Right afterwards, unencrypted non-EAPOL frames are dropped.
>
> So any STA can actually send EAPOL frames with an arbitrary destination
> MAC address except our own into our 802.3 interface. Hence, it looks
> like the first case above is only for having eapol on mgmt iface.
>
> The only problem I see with not doing this is that hostapd will have to
> listen for EAPOL frames on all VLAN interfaces but I suppose that is
> doable.
>
I wonder of port control is done for ethernet. 1X is not WLAN invention.
I'll try to dig it.

> > The problem is the order of the handlers.  First you need to
> > deaggregated the frame then filtered out non EAPLOL frames if the port
> > is not open.
>
> Yeah, I know, I had a plan a while back, will see if I can implement it.
>
Hope to get there as well in near future.

> johannes
>
>

  reply	other threads:[~2007-09-26 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-09 16:15 A-MSDU deaggregation support Johannes Berg
2007-09-10 11:41 ` Tomas Winkler
2007-09-10 11:49   ` Johannes Berg
2007-09-25 19:19   ` Johannes Berg
2007-09-25 23:24     ` Tomas Winkler
2007-09-26  7:39       ` Johannes Berg
2007-09-26 11:46         ` Tomas Winkler [this message]
2007-09-26 12:16           ` Johannes Berg
2007-09-26 12:32             ` Tomas Winkler
2007-09-26 12:37               ` Johannes Berg
2007-09-28  1:39         ` Jouni Malinen
2007-09-28  8:34           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ba2fa240709260446u2facb62fw1a17af1665b25d03@mail.gmail.com \
    --to=tomasw@gmail.com \
    --cc=flamingice@sourmilk.net \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mabbaswireless@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox