From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi: bug in iwl_tx_skb
Date: Fri, 10 Oct 2008 14:20:58 +0200 [thread overview]
Message-ID: <1ba2fa240810100520h7d51624fr468aad2c6def62e2@mail.gmail.com> (raw)
In-Reply-To: <1223543081.22490.2.camel@johannes.berg>
On Thu, Oct 9, 2008 at 11:04 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> When iwl_txq_update_write_ptr fails, you have a huge problem: the skb is
> linked on the queue, the write_ptr has been incremented, but you pretend
> you can just free it.
It's not freed it's should be picket in the next round. We should
really return success to mac80211 in case
HW is not awake which is only sound reason it will fail.
Thanks
Tomas
next prev parent reply other threads:[~2008-10-10 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 9:04 iwlwifi: bug in iwl_tx_skb Johannes Berg
2008-10-10 12:20 ` Tomas Winkler [this message]
2008-10-10 13:27 ` Johannes Berg
2008-10-10 14:36 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240810100520h7d51624fr468aad2c6def62e2@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox