From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi: bug in iwl_tx_skb
Date: Fri, 10 Oct 2008 16:36:50 +0200 [thread overview]
Message-ID: <1ba2fa240810100736r34d652f7i37eb8dfe92a2196a@mail.gmail.com> (raw)
In-Reply-To: <1223645251.3748.0.camel@johannes.berg>
On Fri, Oct 10, 2008 at 3:27 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2008-10-10 at 14:20 +0200, Tomas Winkler wrote:
>> On Thu, Oct 9, 2008 at 11:04 AM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> > When iwl_txq_update_write_ptr fails, you have a huge problem: the skb is
>> > linked on the queue, the write_ptr has been incremented, but you pretend
>> > you can just free it.
>>
>> It's not freed it's should be picket in the next round. We should
>> really return success to mac80211 in case
>
> No, it _is_ freed, by the caller, because you always return success to
> mac80211 anyway and kfree the skb before. And if you didn't return
> success it'd be just as wrong.
Yes I know, as I said we should return success there.
Tomas
prev parent reply other threads:[~2008-10-10 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 9:04 iwlwifi: bug in iwl_tx_skb Johannes Berg
2008-10-10 12:20 ` Tomas Winkler
2008-10-10 13:27 ` Johannes Berg
2008-10-10 14:36 ` Tomas Winkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240810100736r34d652f7i37eb8dfe92a2196a@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox