From: Jean Tourrilhes <jt@hpl.hp.com>
To: Larry Finger <larry.finger@lwfinger.net>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan
Date: Tue, 10 Jul 2007 11:41:55 -0700 [thread overview]
Message-ID: <20070710184155.GA6955@bougret.hpl.hp.com> (raw)
Hi,
SoftMAC output the channel twice in the scan output. It should
display frequency and channel, but only once for each.
--------------------------------------------------------
Cell 02 - Address: A2:00:04:XX:XX:XX
ESSID:"TheESSID"
Protocol:IEEE 802.11b
Mode:Ad-Hoc
-> Channel:5
-> Frequency:2.432 GHz (Channel 5)
Encryption key:off
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s
Quality=95/100 Signal level=-47 dBm Noise level=-65 dBm
Extra: Last beacon: 120ms ago
--------------------------------------------------------
The fix is simple, patch attached, tested for 2.6.22 with
bcm43xx. If you like it, send it to John.
Regards,
Jean
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
-----------------------------------------------------------
--- linux/net/ieee80211/ieee80211_wx.j1.c 2007-07-10 11:28:55.000000000 -0700
+++ linux/net/ieee80211/ieee80211_wx.c 2007-07-10 11:31:18.000000000 -0700
@@ -90,14 +90,11 @@ static char *ieee80211_translate_scan(st
}
/* Add channel and frequency */
+ /* Note : userspace automatically computes channel using iwrange */
iwe.cmd = SIOCGIWFREQ;
- iwe.u.freq.m = network->channel;
- iwe.u.freq.e = 0;
- iwe.u.freq.i = 0;
- start = iwe_stream_add_event(start, stop, &iwe, IW_EV_FREQ_LEN);
-
iwe.u.freq.m = ieee80211_channel_to_freq(ieee, network->channel);
iwe.u.freq.e = 6;
+ iwe.u.freq.i = 0;
start = iwe_stream_add_event(start, stop, &iwe, IW_EV_FREQ_LEN);
/* Add encryption capability */
next reply other threads:[~2007-07-10 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 18:41 Jean Tourrilhes [this message]
2007-07-10 19:25 ` [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan Larry Finger
2007-07-10 19:47 ` Jean Tourrilhes
2007-07-12 3:30 ` Dan Williams
2007-07-12 16:34 ` Jean Tourrilhes
2007-07-12 16:40 ` Larry Finger
2007-07-12 16:49 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070710184155.GA6955@bougret.hpl.hp.com \
--to=jt@hpl.hp.com \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox