Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

[Jean Tourrilhes <jt@hpl.hp.com>]

On Tue, Jul 10, 2007 at 02:25:12PM -0500, Larry Finger wrote:
> Jean,
> 
> Jean Tourrilhes wrote:
> >	Hi,
> >
> >	SoftMAC output the channel twice in the scan output. It should
> >display frequency and channel, but only once for each.
> >--------------------------------------------------------
> >          Cell 02 - Address: A2:00:04:XX:XX:XX
> >                    ESSID:"TheESSID"
> >                    Protocol:IEEE 802.11b
> >                    Mode:Ad-Hoc
> >->                  Channel:5
> >->                  Frequency:2.432 GHz (Channel 5)
> 
> The frequency output is needed by NetworkManager, which is why I added it. 
> At that time, I thought that some tool or other might be scanning the 
> output looking for "Channel:", not "Channel "; therefore I left both in.

	All of the other drivers display only a single line, and
SoftMAC is the odd one here. I think that have the info twice may
confuse some tools.
	I know that there are scripts that parse iwlist output,
however I'm not keen on the practice, as there are alternatives.

> If we are sure that removing the channel-only line will not break
> something, I'll be happy to send your patch upstream.

	Unfortunately, I can't guarantee that. I can only guarantee
that it will be similar to what other drivers do.

> Larry

	Have fun...

	Jean