[PATCH] hostapd: remove use of ieee80211_msg_key_threshold_notification

[PATCH] hostapd: remove use of ieee80211_msg_key_threshold_notification

[Johannes Berg]

The code is #if 0'ed anyway, so might as well not use the constant.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

--- hostap.orig/hostapd/driver_devicescape.c	2007-08-10 23:42:58.000000000 +0200
+++ hostap/hostapd/driver_devicescape.c	2007-08-10 23:43:43.000000000 +0200
@@ -1342,13 +1342,17 @@ static void handle_frame(struct hostapd_
 		return;
 	}
 #endif
+# if 0
+/* TODO
+ * get key notification from kernel again... it doesn't give one now
+ * because this code doesn't care
+ */
 	if (msg_type == ieee80211_msg_key_threshold_notification) {
-#if 0 /* TODO */
 		ieee802_11_key_threshold_notification(iface->bss[0], buf,
 						      data_len);
-#endif
 		return;
 	}
+#endif
 
 	/* PS-Poll frame from not associated is 16 bytes. All other frames
 	 * passed to hostapd are 24 bytes or longer.

Re: [PATCH] hostapd: remove use of ieee80211_msg_key_threshold_notification

[Jouni Malinen]

On Fri, Aug 10, 2007 at 11:44:45PM +0200, Johannes Berg wrote:
> The code is #if 0'ed anyway, so might as well not use the constant.

Just like ieee80211_msg_sta_not_assoc, this one is a useful notification
and I would rather not see it being removed. Consequently, I did not
apply this. I would be much more open to changing this notification to
use some other mechanism if there is a reason to get rid of
ieee80211_msg_* types, but just removing this because the code is
currently #if 0'ed in hostapd is not a reason I would support.

-- 
Jouni Malinen                                            PGP id EFC895FA

Re: [PATCH] hostapd: remove use of ieee80211_msg_key_threshold_notification

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

On Tue, 2007-08-14 at 20:43 -0700, Jouni Malinen wrote:

> Just like ieee80211_msg_sta_not_assoc, this one is a useful notification
> and I would rather not see it being removed. Consequently, I did not
> apply this. I would be much more open to changing this notification to
> use some other mechanism if there is a reason to get rid of
> ieee80211_msg_* types, but just removing this because the code is
> currently #if 0'ed in hostapd is not a reason I would support.

Same as with the other one, I'd like to get rid of the ieee80211_msg_*
stuff with the hacked-up prism2 monitor mode header. Again, here I've
extended the TODO item to cover both sides, where the implementation
ought to be in nl80211.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]