[PATCH] libertas: make lbs_unset_basic_rate_flags() static

[PATCH] libertas: make lbs_unset_basic_rate_flags() static

[Holger Schurig]

... by moving it into the file where it's sole user resides

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Index: wireless-2.6/drivers/net/wireless/libertas/join.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/libertas/join.c	2008-01-17 10:31:26.000000000 +0100
+++ wireless-2.6/drivers/net/wireless/libertas/join.c	2008-01-17 10:32:01.000000000 +0100
@@ -99,23 +99,6 @@ static void lbs_set_basic_rate_flags(u8 
 }
 
 /**
- *  @brief Unsets the MSB on basic rates
- *
- * Scan through an array and unset the MSB for basic data rates.
- *
- *  @param rates     buffer of data rates
- *  @param len       size of buffer
- */
-void lbs_unset_basic_rate_flags(u8 *rates, size_t len)
-{
-	int i;
-
-	for (i = 0; i < len; i++)
-		rates[i] &= 0x7f;
-}
-
-
-/**
  *  @brief Associate to a specific BSS discovered in a scan
  *
  *  @param priv      A pointer to struct lbs_private structure
Index: wireless-2.6/drivers/net/wireless/libertas/join.h
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/libertas/join.h	2008-01-17 10:32:17.000000000 +0100
+++ wireless-2.6/drivers/net/wireless/libertas/join.h	2008-01-17 10:32:21.000000000 +0100
@@ -48,6 +48,4 @@ int lbs_send_deauthentication(struct lbs
 
 int lbs_associate(struct lbs_private *priv, struct assoc_request *assoc_req);
 
-void lbs_unset_basic_rate_flags(u8 *rates, size_t len);
-
 #endif
Index: wireless-2.6/drivers/net/wireless/libertas/scan.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/libertas/scan.c	2008-01-17 10:31:26.000000000 +0100
+++ wireless-2.6/drivers/net/wireless/libertas/scan.c	2008-01-17 10:31:53.000000000 +0100
@@ -73,6 +73,23 @@ static const u8 bcastmac[ETH_ALEN] = { 0
 /*                                                                   */
 /*********************************************************************/
 
+/**
+ *  @brief Unsets the MSB on basic rates
+ *
+ * Scan through an array and unset the MSB for basic data rates.
+ *
+ *  @param rates     buffer of data rates
+ *  @param len       size of buffer
+ */
+static void lbs_unset_basic_rate_flags(u8 *rates, size_t len)
+{
+	int i;
+
+	for (i = 0; i < len; i++)
+		rates[i] &= 0x7f;
+}
+
+
 static inline void clear_bss_descriptor (struct bss_descriptor * bss)
 {
 	/* Don't blow away ->list, just BSS data */

Re: [PATCH] libertas: make lbs_unset_basic_rate_flags() static

[Dan Williams]

On Mon, 2008-01-28 at 17:27 +0100, Holger Schurig wrote:
> ... by moving it into the file where it's sole user resides
> 
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Acked-by: Dan Williams <dcbw@redhat.com>

> Index: wireless-2.6/drivers/net/wireless/libertas/join.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/join.c	2008-01-17 10:31:26.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/join.c	2008-01-17 10:32:01.000000000 +0100
> @@ -99,23 +99,6 @@ static void lbs_set_basic_rate_flags(u8 
>  }
>  
>  /**
> - *  @brief Unsets the MSB on basic rates
> - *
> - * Scan through an array and unset the MSB for basic data rates.
> - *
> - *  @param rates     buffer of data rates
> - *  @param len       size of buffer
> - */
> -void lbs_unset_basic_rate_flags(u8 *rates, size_t len)
> -{
> -	int i;
> -
> -	for (i = 0; i < len; i++)
> -		rates[i] &= 0x7f;
> -}
> -
> -
> -/**
>   *  @brief Associate to a specific BSS discovered in a scan
>   *
>   *  @param priv      A pointer to struct lbs_private structure
> Index: wireless-2.6/drivers/net/wireless/libertas/join.h
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/join.h	2008-01-17 10:32:17.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/join.h	2008-01-17 10:32:21.000000000 +0100
> @@ -48,6 +48,4 @@ int lbs_send_deauthentication(struct lbs
>  
>  int lbs_associate(struct lbs_private *priv, struct assoc_request *assoc_req);
>  
> -void lbs_unset_basic_rate_flags(u8 *rates, size_t len);
> -
>  #endif
> Index: wireless-2.6/drivers/net/wireless/libertas/scan.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/scan.c	2008-01-17 10:31:26.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/scan.c	2008-01-17 10:31:53.000000000 +0100
> @@ -73,6 +73,23 @@ static const u8 bcastmac[ETH_ALEN] = { 0
>  /*                                                                   */
>  /*********************************************************************/
>  
> +/**
> + *  @brief Unsets the MSB on basic rates
> + *
> + * Scan through an array and unset the MSB for basic data rates.
> + *
> + *  @param rates     buffer of data rates
> + *  @param len       size of buffer
> + */
> +static void lbs_unset_basic_rate_flags(u8 *rates, size_t len)
> +{
> +	int i;
> +
> +	for (i = 0; i < len; i++)
> +		rates[i] &= 0x7f;
> +}
> +
> +
>  static inline void clear_bss_descriptor (struct bss_descriptor * bss)
>  {
>  	/* Don't blow away ->list, just BSS data */