Linux wireless drivers development
 help / color / mirror / Atom feed
* [patch 1/1] b43: fix build with CONFIG_SSB_PCIHOST=n
@ 2008-02-05  7:58 akpm
  2008-02-05  8:23 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-02-05  7:58 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless, akpm, mb

From: Andrew Morton <akpm@linux-foundation.org>

m68k allmodconfig gives

drivers/net/wireless/b43/main.c:251: error: implicit declaration of function 'mmiowb'

because CONFIG_B43=m, CONFIG_SSB_PCIHOST=n.

Might be Kconfig bustage, but this works...

Cc: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/linux/ssb/ssb.h |    9 +++++++++
 1 file changed, 9 insertions(+)

diff -puN include/linux/ssb/ssb.h~b43-fix-build-with-config_ssb_pcihost=n include/linux/ssb/ssb.h
--- a/include/linux/ssb/ssb.h~b43-fix-build-with-config_ssb_pcihost=n
+++ a/include/linux/ssb/ssb.h
@@ -373,6 +373,15 @@ void ssb_pcihost_set_power_state(struct 
 	if (sdev->bus->bustype == SSB_BUSTYPE_PCI)
 		pci_set_power_state(sdev->bus->host_pci, state);
 }
+#else
+static inline void ssb_pcihost_unregister(struct pci_driver *driver)
+{
+}
+
+static inline
+void ssb_pcihost_set_power_state(struct ssb_device *sdev, pci_power_t state)
+{
+}
 #endif /* CONFIG_SSB_PCIHOST */
 
 
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/1] b43: fix build with CONFIG_SSB_PCIHOST=n
  2008-02-05  7:58 [patch 1/1] b43: fix build with CONFIG_SSB_PCIHOST=n akpm
@ 2008-02-05  8:23 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-02-05  8:23 UTC (permalink / raw)
  To: akpm; +Cc: linville, linux-wireless, mb

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]


On Mon, 2008-02-04 at 23:58 -0800, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> m68k allmodconfig gives
> 
> drivers/net/wireless/b43/main.c:251: error: implicit declaration of function 'mmiowb'
> 
> because CONFIG_B43=m, CONFIG_SSB_PCIHOST=n.
> 
> Might be Kconfig bustage, but this works...

It's not Kcconfig bustage and I agree with this patch more than the one
posted on netdev recently fixing it specifically in b44 (rather than
like this patch that fixes them both at once).

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-05  8:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-05  7:58 [patch 1/1] b43: fix build with CONFIG_SSB_PCIHOST=n akpm
2008-02-05  8:23 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox