DS params only in 2GHz band?

DS params only in 2GHz band?

[bruno randolf]

hello johannes!

in your commit e1251b1d3c0e12a481c4c6b3ef60dfdf0f6be8c1:
> @@ -2945,10 +2968,12 @@ static int ieee80211_sta_join_ibss(struct
> net_device *dev, *pos++ = rates;
>                 memcpy(pos, bss->supp_rates, rates);
>
> -               pos = skb_put(skb, 2 + 1);
> -               *pos++ = WLAN_EID_DS_PARAMS;
> -               *pos++ = 1;
> -               *pos++ = bss->channel;
> +               if (bss->band == IEEE80211_BAND_2GHZ) {
> +                       pos = skb_put(skb, 2 + 1);
> +                       *pos++ = WLAN_EID_DS_PARAMS;
> +                       *pos++ = 1;
> +                       *pos++ = ieee80211_frequency_to_channel(bss->freq);
> +               }
>
>                 pos = skb_put(skb, 2 + 2);
>                 *pos++ = WLAN_EID_IBSS_PARAMS;

what's the reason you changed the beacons to include DS params only in the 
2GHz band?

thanks,
bruno

Re: DS params only in 2GHz band?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]


> > +               if (bss->band == IEEE80211_BAND_2GHZ) {
> > +                       pos = skb_put(skb, 2 + 1);
> > +                       *pos++ = WLAN_EID_DS_PARAMS;
> > +                       *pos++ = 1;
> > +                       *pos++ = ieee80211_frequency_to_channel(bss->freq);
> > +               }
> >
> >                 pos = skb_put(skb, 2 + 2);
> >                 *pos++ = WLAN_EID_IBSS_PARAMS;
> 
> what's the reason you changed the beacons to include DS params only in the 
> 2GHz band?

IEEE 802.11 7.3.2.4:

The DS Parameter Set element contains information to allow channel
number identification for STAs using a DSSS PHY.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]