From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Henning Rogge <hrogge@googlemail.com>
Subject: Re: [RFC] mac80211: Add HT rates into RX status reporting
Date: Thu, 11 Dec 2008 21:22:51 +0200 [thread overview]
Message-ID: <20081211192251.GA5170@jm.kir.nu> (raw)
In-Reply-To: <1229019768.8081.53.camel@johannes.berg>
On Thu, Dec 11, 2008 at 07:22:48PM +0100, Johannes Berg wrote:
> On Thu, 2008-12-11 at 20:15 +0200, Jouni Malinen wrote:
> > Yes. FreeBSD radiotap definition uses 0x80 as a flag in the rate field
> > for indicating that it is an MCS index, not bitrate.
> Ugh. Nobody will dissect that properly.
Actually, wireshark seems to have code to dissect that..
> Do you actually need this
> information in userland _now_? Otherwise, Dave Young is moving the list
> elsewhere and then we can properly define this in radiotap rather than
> going with some other set. 0x80 in flags (not rate) is used to indicate
> short-GI in wireshark, and it's all very confusing... I'd rather see a
> new "HT rate" field added to radiotap.
Well, yes, I do need it like yesterday. I really want to have a reliable
sniffer that I can trust on providing correct information about received
frames. I can obviously handle a personal patch that adds this, but it
gets more complex when asking others to capture some frames for you..
Anyway, I will move the radiotap parts into a separate patch and leave
it to others to decide whether that should go in now or not. The best
option (if John is willing) would likely be to get the first part
(mac80211 driver API addition and ath9k fix/cleanup) in and pushed
upstream while the radiotap parts would be maintained only in
wireless-testing for the time being.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2008-12-11 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 16:17 [RFC] mac80211: Add HT rates into RX status reporting Jouni Malinen
2008-12-11 17:16 ` Johannes Berg
2008-12-11 18:15 ` Jouni Malinen
2008-12-11 18:22 ` Johannes Berg
2008-12-11 19:22 ` Jouni Malinen [this message]
2008-12-11 19:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211192251.GA5170@jm.kir.nu \
--to=j@w1.fi \
--cc=hrogge@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox