From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Tomas Winkler <tomasw@gmail.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH 1/1] iwmc3200: add more SDIO device ids
Date: Wed, 26 Aug 2009 09:25:03 +0200 [thread overview]
Message-ID: <200908260925.03437.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1251156118.2950.82.camel@localhost.localdomain>
On Tuesday 25 August 2009 01:21:58 Marcel Holtmann wrote:
> My personal vote is for keeping all IDs inside the drivers.
> And I also prefer to keep the plain hex values and just put a
> comment above them which device this is. Something like this:
>
> static struct usb_device_id btusb_table[] = {
> /* Generic Bluetooth USB device */
> { USB_DEVICE_INFO(0xe0, 0x01, 0x01) },
+1
When I have an unknown device (and not compiled all modules) it's
so much easier to do an
grep -ri 057c drivers/usb
then to do the same on include/ and then again to find the driver
that uses this id. For the same reason, I prefer 0x057c in the
source and not 0x57c.
--
http://www.holgerschurig.de
prev parent reply other threads:[~2009-08-26 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 21:34 [PATCH 1/1] iwmc3200: add more SDIO device ids Tomas Winkler
2009-08-24 21:36 ` Luis R. Rodriguez
2009-08-24 22:20 ` Tomas Winkler
2009-08-24 22:29 ` Luis R. Rodriguez
2009-08-24 22:37 ` Bob Copeland
2009-08-24 23:21 ` Marcel Holtmann
2009-08-26 7:25 ` Holger Schurig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908260925.03437.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox