[PATCH 1/1] iwmc3200: add more SDIO device ids

[PATCH 1/1] iwmc3200: add more SDIO device ids

[Tomas Winkler]

add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids

Cc:inaky.perez-gonzalez@intel.com
Cc:cindy.h.kao@intel.com
Cc:yi.zhu@intel.com
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 include/linux/mmc/sdio_ids.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
index 2dbfb5a..addd456 100644
--- a/include/linux/mmc/sdio_ids.h
+++ b/include/linux/mmc/sdio_ids.h
@@ -28,6 +28,8 @@
 #define SDIO_DEVICE_ID_INTEL_IWMC3200TOP	0x1404
 #define SDIO_DEVICE_ID_INTEL_IWMC3200GPS	0x1405
 #define SDIO_DEVICE_ID_INTEL_IWMC3200BT		0x1406
+#define SDIO_DEVICE_ID_INTEL_IWMC3200WIMAX_24	0x1407
+#define SDIO_DEVICE_ID_INTEL_IWMC3200WIFI_BGN	0x1408
 
 #define SDIO_VENDOR_ID_MARVELL			0x02df
 #define SDIO_DEVICE_ID_MARVELL_LIBERTAS		0x9103
-- 
1.6.0.6

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Luis R. Rodriguez]

On Mon, Aug 24, 2009 at 2:34 PM, Tomas Winkler<tomas.winkler@intel.com> wrote:
> add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids
>
> Cc:inaky.perez-gonzalez@intel.com
> Cc:cindy.h.kao@intel.com
> Cc:yi.zhu@intel.com
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Since it seems we are preferring to not do this for PCI for cases
where the ID will only be used for 1 device perhaps its best to remove
all those ids and stuff them directly into the intel driver itself
that will use it.

  Luis

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Tomas Winkler]

On Tue, Aug 25, 2009 at 12:36 AM, Luis R. Rodriguez<mcgrof@gmail.com> wrote:
> On Mon, Aug 24, 2009 at 2:34 PM, Tomas Winkler<tomas.winkler@intel.com> wrote:
>> add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids
>>
>> Cc:inaky.perez-gonzalez@intel.com
>> Cc:cindy.h.kao@intel.com
>> Cc:yi.zhu@intel.com
>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Since it seems we are preferring to not do this for PCI for cases
> where the ID will only be used for 1 device perhaps its best to remove
> all those ids and stuff them directly into the intel driver itself
> that will use it.
>
I don't have strong opinion about it but this is the current habit
IIRC there was a mail thread that explicitly asked to move SDIO IDs
there,  of course I cannot locate it right now :(

Thanks
Tomas

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Luis R. Rodriguez]

On Mon, Aug 24, 2009 at 3:20 PM, Tomas Winkler<tomasw@gmail.com> wrote:
> On Tue, Aug 25, 2009 at 12:36 AM, Luis R. Rodriguez<mcgrof@gmail.com> wrote:
>> On Mon, Aug 24, 2009 at 2:34 PM, Tomas Winkler<tomas.winkler@intel.com> wrote:
>>> add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids
>>>
>>> Cc:inaky.perez-gonzalez@intel.com
>>> Cc:cindy.h.kao@intel.com
>>> Cc:yi.zhu@intel.com
>>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>>
>> Since it seems we are preferring to not do this for PCI for cases
>> where the ID will only be used for 1 device perhaps its best to remove
>> all those ids and stuff them directly into the intel driver itself
>> that will use it.
>>
> I don't have strong opinion about it but this is the current habit
> IIRC there was a mail thread that explicitly asked to move SDIO IDs
> there,  of course I cannot locate it right now :(

Sure, understood, whoever maintains this should decide.

  Luis

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Bob Copeland]

On Mon, Aug 24, 2009 at 6:20 PM, Tomas Winkler<tomasw@gmail.com> wrote:
> I don't have strong opinion about it but this is the current habit
> IIRC there was a mail thread that explicitly asked to move SDIO IDs
> there,  of course I cannot locate it right now :(

This one:
http://marc.info/?l=linux-wireless&m=124489211911222&w=2

Of course, Pierre is no longer maintainer and there are only a few
IDs there, so I don't think anyone will shout either way.

-- 
Bob Copeland %% www.bobcopeland.com

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Marcel Holtmann]

Hi Tomas,

> >> add WiFi BGN SKU and WiMAX 2.4GHz SKU device ids
> >>
> >> Cc:inaky.perez-gonzalez@intel.com
> >> Cc:cindy.h.kao@intel.com
> >> Cc:yi.zhu@intel.com
> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > Since it seems we are preferring to not do this for PCI for cases
> > where the ID will only be used for 1 device perhaps its best to remove
> > all those ids and stuff them directly into the intel driver itself
> > that will use it.
> >
> I don't have strong opinion about it but this is the current habit
> IIRC there was a mail thread that explicitly asked to move SDIO IDs
> there,  of course I cannot locate it right now :(

first thing is that IDs should only be added if there are users for it.
I am missing the patches that are actually using them. Send them all
together.

Second, we have to establish what is the preferred method of IDs for the
SDIO subsystem. In general I would prefer we have a global policy for
this, but in reality it is up to the subsystem maintainers.

My personal vote is for keeping all IDs inside the drivers. And I also
prefer to keep the plain hex values and just put a comment above them
which device this is. Something like this:

static struct usb_device_id btusb_table[] = {
	/* Generic Bluetooth USB device */
	{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },

	/* AVM BlueFRITZ! USB v2.0 */
	{ USB_DEVICE(0x057c, 0x3800) },

	{ }	/* Terminating entry */
};

Regards

Marcel

Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

[Holger Schurig]

On Tuesday 25 August 2009 01:21:58 Marcel Holtmann wrote:
> My personal vote is for keeping all IDs inside the drivers.
> And I also prefer to keep the plain hex values and just put a
> comment above them which device this is. Something like this:
>
> static struct usb_device_id btusb_table[] = {
> 	/* Generic Bluetooth USB device */
> 	{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },

+1

When I have an unknown device (and not compiled all modules) it's 
so much easier to do an

grep -ri 057c drivers/usb

then to do the same on include/ and then again to find the driver 
that uses this id. For the same reason, I prefer 0x057c in the 
source and not 0x57c.

-- 
http://www.holgerschurig.de