Re: sony-laptop: check for rfkill hard block at load time

Re: sony-laptop: check for rfkill hard block at load time

[Norbert Preining]

[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]

On Thu, 24 Sep 2009, Alan Jenkins wrote:
> We can fix this by querying the firmware at load time and calling
> rfkill_set_hw_state().

The bug concerning checking the state after suspend to ram should probably
be also queued. Original email attached.

Tested-by: Norbert Preining <preining@logic.at>

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
SWANAGE (pl.n.)
Swanage is the series of diversionary tactics used when trying to
cover up the existence of a glossop (q.v.) and may include (a)
uttering a high-pitched laugh and pointing out of the window (NB. this
doesn't work more that twice); (b) sneezing as loudly as possible and
wiping the glossop off the table in the same movement as whipping out
your handkerchief; (c) saying 'Christ! I seen to have dropped some
shit on your table' (very unwise); (d) saying 'Christ, who did that?'
(better) (e) pressing your elbow on the glossop itself and working
your arms slowly to the edge of the table; (f) leaving the glossop
where it is but moving a plate over it and putting up with sitting at
an uncomfortable angle the rest of the meal; or, if the glossop is in
too exposed a position, (g) leaving it there unremarked except for the
occasional humorous glance.
			--- Douglas Adams, The Meaning of Liff

[-- Attachment #2: Type: message/rfc822, Size: 4576 bytes --]

From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, Mattia Dongili <malattia@linux.it>, Norbert Preining <preining@logic.at>
Subject: [PATCH] [RFT] sony-laptop: re-read the rfkill state when resuming from suspend
Date: Fri, 25 Sep 2009 10:18:21 +0100
Message-ID: <4ABC8ADD.3090803@tuffmail.co.uk>

Without this, the hard-blocked state will be reported incorrectly if
the hardware switch is changed while the laptop is suspended.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
--

Again, this is from code inspection only.  Since suspend/resume can
be tricky, please test that this change works (and is necessary).


diff a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -1044,6 +1044,9 @@ static int sony_nc_resume(struct acpi_device *device)
 			sony_backlight_update_status(sony_backlight_device) < 0)
 		printk(KERN_WARNING DRV_PFX "unable to restore brightness level\n");
 
+	/* re-read rfkill state */
+	sony_nc_rfkill_update();
+
 	return 0;
 }
 

Re: sony-laptop: check for rfkill hard block at load time

[Greg KH]

On Fri, Oct 02, 2009 at 07:00:29PM +0900, Norbert Preining wrote:
> On Thu, 24 Sep 2009, Alan Jenkins wrote:
> > We can fix this by querying the firmware at load time and calling
> > rfkill_set_hw_state().
> 
> The bug concerning checking the state after suspend to ram should probably
> be also queued. Original email attached.

Queued for what?

confused,

greg k-h

Re: sony-laptop: check for rfkill hard block at load time

[Norbert Preining]

On Fr, 02 Okt 2009, Greg KH wrote:
> On Fri, Oct 02, 2009 at 07:00:29PM +0900, Norbert Preining wrote:
> > On Thu, 24 Sep 2009, Alan Jenkins wrote:
> > > We can fix this by querying the firmware at load time and calling
> > > rfkill_set_hw_state().
> > 
> > The bug concerning checking the state after suspend to ram should probably
> > be also queued. Original email attached.
> 
> Queued for what?

Queued for inclusion into 2.6.3N (for N>=2), that is what the original email
was stating. Sorry if I stripped it down to far.

Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at>        Vienna University of Technology
Debian Developer <preining@debian.org>                         Debian TeX Group
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
HIBBING (n.)
The marks left on the outside breast pocket of a storekeeper's overall
where he has put away his pen and missed.
			--- Douglas Adams, The Meaning of Liff