public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Bala Shanmugam <sbalashanmugam@atheros.com>
To: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	<mcgrof@bombadil.infradead.org>
Cc: Jothikumar Mothilal <Jothikumar.Mothilal@Atheros.com>,
	<linux-wireless@vger.kernel.org>
Subject: [RFC]compat-wireless: modules declared as PHONY target in Makefile
Date: Thu, 17 Dec 2009 18:12:25 +0530	[thread overview]
Message-ID: <20091217124225.GA3068@atheros-laptop> (raw)

When a particular file alone is modified in compat package, it is not compiled with make.
To compile the modified file compat package needs to be cleaned up and all files need to be compiled.
This is because all files are compiled in modules target, and file by name modules is not generated.
So this target will be considered up-to-date once compiled.

modules target is declared as PHONY target to avoid this problem.

I feel config.mk need not be included when KERNELRELEASE is not NULL as
it degrades the performance and doesn't make any difference.  Please comment.

Signed-off-by: Bala Shanmugam <sbalashanmugam@atheros.com>
---
 Makefile |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 66790f2..85fb9fe 100644
--- a/Makefile
+++ b/Makefile
@@ -15,8 +15,6 @@ DESTDIR?=
 
 ifneq ($(KERNELRELEASE),)
 
-include $(M)/$(COMPAT_CONFIG)
-
 NOSTDINC_FLAGS := -I$(M)/include/ -include $(M)/include/linux/compat-2.6.h $(CFLAGS)
 
 obj-y := compat/
@@ -295,7 +293,7 @@ wlunload:
 wlload: wlunload
 	@./scripts/wlload.sh
 
-.PHONY: all clean install uninstall unload load btunload btload wlunload wlload
+.PHONY: all clean install uninstall unload load btunload btload wlunload wlload modules
 
 endif
 
-- 
1.6.0.4


             reply	other threads:[~2009-12-17 12:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17 12:42 Bala Shanmugam [this message]
2009-12-19  1:18 ` [RFC]compat-wireless: modules declared as PHONY target in Makefile Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217124225.GA3068@atheros-laptop \
    --to=sbalashanmugam@atheros.com \
    --cc=Jothikumar.Mothilal@Atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@bombadil.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox