From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Bala Shanmugam <sbalashanmugam@atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@atheros.com>,
mcgrof@bombadil.infradead.org,
Jothikumar Mothilal <Jothikumar.Mothilal@atheros.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC]compat-wireless: modules declared as PHONY target in Makefile
Date: Fri, 18 Dec 2009 17:18:12 -0800 [thread overview]
Message-ID: <43e72e890912181718r78ea33eand142bf79f60daac@mail.gmail.com> (raw)
In-Reply-To: <20091217124225.GA3068@atheros-laptop>
On Thu, Dec 17, 2009 at 4:42 AM, Bala Shanmugam
<sbalashanmugam@atheros.com> wrote:
> When a particular file alone is modified in compat package, it is not compiled with make.
> To compile the modified file compat package needs to be cleaned up and all files need to be compiled.
> This is because all files are compiled in modules target, and file by name modules is not generated.
> So this target will be considered up-to-date once compiled.
>
> modules target is declared as PHONY target to avoid this problem.
>
> I feel config.mk need not be included when KERNELRELEASE is not NULL as
> it degrades the performance and doesn't make any difference. Please comment.
>
> Signed-off-by: Bala Shanmugam <sbalashanmugam@atheros.com>
I was wondering what caused that to happen, thanks applied.
Luis
prev parent reply other threads:[~2009-12-19 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 12:42 [RFC]compat-wireless: modules declared as PHONY target in Makefile Bala Shanmugam
2009-12-19 1:18 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890912181718r78ea33eand142bf79f60daac@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=Jothikumar.Mothilal@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
--cc=sbalashanmugam@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox