From: Andrew Morton <akpm@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "John W. Linville" <linville@tuxdriver.com>,
stable@kernel.org, linux-wireless@vger.kernel.org,
Gertjan van Wingerde <gwingerde@gmail.com>,
Ivo van Doorn <IvDoorn@gmail.com>,
Krister Svanlund <krister.svanlund@gmail.com>,
bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress
Date: Mon, 25 Jan 2010 16:28:35 -0800 [thread overview]
Message-ID: <20100125162835.6619e3f4.akpm@linux-foundation.org> (raw)
In-Reply-To: <bug-15089-10286@http.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Tue, 19 Jan 2010 14:35:03 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=15089
2.6.32.2 -> 2.6.32.3 regression. Hence the regression is probably in
2.6.33-rc.
Looking through the changelog I'd be suspecting
: commit 3815270b3107d31c8b7bd69461f0bb3c350ee25c
: Author: Gertjan van Wingerde <gwingerde@gmail.com>
: Date: Mon Dec 14 20:33:55 2009 +0100
:
: rt2x00: Disable powersaving for rt61pci and rt2800pci.
:
: commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.
Mainly because I didn't spot any other change to that driver.
Krister, are you able to apply this reversion patch to 2.6.32.3 and see
if it helps?
Thanks.
drivers/net/wireless/rt2x00/rt2800lib.c | 6 ------
drivers/net/wireless/rt2x00/rt61pci.c | 5 -----
2 files changed, 11 deletions(-)
diff -puN drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 drivers/net/wireless/rt2x00/rt2800lib.c
--- a/drivers/net/wireless/rt2x00/rt2800lib.c~revert-1
+++ a/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2037,12 +2037,6 @@ int rt2800_probe_hw_mode(struct rt2x00_d
u16 eeprom;
/*
- * Disable powersaving as default on PCI devices.
- */
- if (rt2x00_intf_is_pci(rt2x00dev))
- rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
- /*
* Initialize all hw fields.
*/
rt2x00dev->hw->flags =
diff -puN drivers/net/wireless/rt2x00/rt61pci.c~revert-1 drivers/net/wireless/rt2x00/rt61pci.c
--- a/drivers/net/wireless/rt2x00/rt61pci.c~revert-1
+++ a/drivers/net/wireless/rt2x00/rt61pci.c
@@ -2535,11 +2535,6 @@ static int rt61pci_probe_hw_mode(struct
unsigned int i;
/*
- * Disable powersaving as default.
- */
- rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
- /*
* Initialize all hw fields.
*/
rt2x00dev->hw->flags =
_
next parent reply other threads:[~2010-01-26 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-15089-10286@http.bugzilla.kernel.org/>
2010-01-26 0:28 ` Andrew Morton [this message]
2010-01-26 0:51 ` [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress Krister Svanlund
2010-01-26 2:57 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125162835.6619e3f4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=IvDoorn@gmail.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=gwingerde@gmail.com \
--cc=krister.svanlund@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox