* Re: [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress
[not found] <bug-15089-10286@http.bugzilla.kernel.org/>
@ 2010-01-26 0:28 ` Andrew Morton
2010-01-26 0:51 ` Krister Svanlund
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2010-01-26 0:28 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: John W. Linville, stable, linux-wireless, Gertjan van Wingerde,
Ivo van Doorn, Krister Svanlund, bugzilla-daemon, bugme-daemon
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Tue, 19 Jan 2010 14:35:03 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=15089
2.6.32.2 -> 2.6.32.3 regression. Hence the regression is probably in
2.6.33-rc.
Looking through the changelog I'd be suspecting
: commit 3815270b3107d31c8b7bd69461f0bb3c350ee25c
: Author: Gertjan van Wingerde <gwingerde@gmail.com>
: Date: Mon Dec 14 20:33:55 2009 +0100
:
: rt2x00: Disable powersaving for rt61pci and rt2800pci.
:
: commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.
Mainly because I didn't spot any other change to that driver.
Krister, are you able to apply this reversion patch to 2.6.32.3 and see
if it helps?
Thanks.
drivers/net/wireless/rt2x00/rt2800lib.c | 6 ------
drivers/net/wireless/rt2x00/rt61pci.c | 5 -----
2 files changed, 11 deletions(-)
diff -puN drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 drivers/net/wireless/rt2x00/rt2800lib.c
--- a/drivers/net/wireless/rt2x00/rt2800lib.c~revert-1
+++ a/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2037,12 +2037,6 @@ int rt2800_probe_hw_mode(struct rt2x00_d
u16 eeprom;
/*
- * Disable powersaving as default on PCI devices.
- */
- if (rt2x00_intf_is_pci(rt2x00dev))
- rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
- /*
* Initialize all hw fields.
*/
rt2x00dev->hw->flags =
diff -puN drivers/net/wireless/rt2x00/rt61pci.c~revert-1 drivers/net/wireless/rt2x00/rt61pci.c
--- a/drivers/net/wireless/rt2x00/rt61pci.c~revert-1
+++ a/drivers/net/wireless/rt2x00/rt61pci.c
@@ -2535,11 +2535,6 @@ static int rt61pci_probe_hw_mode(struct
unsigned int i;
/*
- * Disable powersaving as default.
- */
- rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
-
- /*
* Initialize all hw fields.
*/
rt2x00dev->hw->flags =
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress
2010-01-26 0:28 ` [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress Andrew Morton
@ 2010-01-26 0:51 ` Krister Svanlund
2010-01-26 2:57 ` [stable] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Krister Svanlund @ 2010-01-26 0:51 UTC (permalink / raw)
To: Andrew Morton
Cc: Rafael J. Wysocki, John W. Linville, stable, linux-wireless,
Gertjan van Wingerde, Ivo van Doorn, bugzilla-daemon,
bugme-daemon
No sorry, I'm currently not capable to recompile my kernel. I hope
someone else with a similar problem comes along.
On Tue, Jan 26, 2010 at 1:28 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
>
> (switched to email. Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
>
>
> On Tue, 19 Jan 2010 14:35:03 GMT
> bugzilla-daemon@bugzilla.kernel.org wrote:
>
>> http://bugzilla.kernel.org/show_bug.cgi?id=15089
>
> 2.6.32.2 -> 2.6.32.3 regression. Hence the regression is probably in
> 2.6.33-rc.
>
> Looking through the changelog I'd be suspecting
>
>
> : commit 3815270b3107d31c8b7bd69461f0bb3c350ee25c
> : Author: Gertjan van Wingerde <gwingerde@gmail.com>
> : Date: Mon Dec 14 20:33:55 2009 +0100
> :
> : rt2x00: Disable powersaving for rt61pci and rt2800pci.
> :
> : commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.
>
> Mainly because I didn't spot any other change to that driver.
>
>
> Krister, are you able to apply this reversion patch to 2.6.32.3 and see
> if it helps?
>
> Thanks.
>
>
> drivers/net/wireless/rt2x00/rt2800lib.c | 6 ------
> drivers/net/wireless/rt2x00/rt61pci.c | 5 -----
> 2 files changed, 11 deletions(-)
>
> diff -puN drivers/net/wireless/rt2x00/rt2800lib.c~revert-1 drivers/net/wireless/rt2x00/rt2800lib.c
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c~revert-1
> +++ a/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2037,12 +2037,6 @@ int rt2800_probe_hw_mode(struct rt2x00_d
> u16 eeprom;
>
> /*
> - * Disable powersaving as default on PCI devices.
> - */
> - if (rt2x00_intf_is_pci(rt2x00dev))
> - rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> -
> - /*
> * Initialize all hw fields.
> */
> rt2x00dev->hw->flags =
> diff -puN drivers/net/wireless/rt2x00/rt61pci.c~revert-1 drivers/net/wireless/rt2x00/rt61pci.c
> --- a/drivers/net/wireless/rt2x00/rt61pci.c~revert-1
> +++ a/drivers/net/wireless/rt2x00/rt61pci.c
> @@ -2535,11 +2535,6 @@ static int rt61pci_probe_hw_mode(struct
> unsigned int i;
>
> /*
> - * Disable powersaving as default.
> - */
> - rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> -
> - /*
> * Initialize all hw fields.
> */
> rt2x00dev->hw->flags =
> _
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [stable] [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress
2010-01-26 0:51 ` Krister Svanlund
@ 2010-01-26 2:57 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2010-01-26 2:57 UTC (permalink / raw)
To: Krister Svanlund
Cc: Andrew Morton, bugzilla-daemon, Gertjan van Wingerde,
Ivo van Doorn, linux-wireless, John W. Linville,
Rafael J. Wysocki, bugme-daemon, stable
On Tue, Jan 26, 2010 at 01:51:16AM +0100, Krister Svanlund wrote:
> No sorry, I'm currently not capable to recompile my kernel. I hope
> someone else with a similar problem comes along.
Then how do you know the regression happened between 2.6.32.2 and
2.6.32.3?
confused,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-26 3:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-15089-10286@http.bugzilla.kernel.org/>
2010-01-26 0:28 ` [Bugme-new] [Bug 15089] New: Fail to get ethernet IP-adress Andrew Morton
2010-01-26 0:51 ` Krister Svanlund
2010-01-26 2:57 ` [stable] " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox