From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Fix rx of mcast/bcast frames in PS mode with auto sleep
Date: Sat, 22 May 2010 23:48:15 -0700 [thread overview]
Message-ID: <20100523064814.GB21298@vasanth-laptop> (raw)
In-Reply-To: <8739xjiwjj.fsf@purkki.valot.fi>
On Sun, May 23, 2010 at 12:38:48AM +0530, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <vasanth@atheros.com> writes:
>
> > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
>
> Please describe more, this isn't very informative (if any). Especially
> try to answer in the commit log:
>
> o What was the original bug? How and why did it happen?
> o How was it visible to the user?
> o How does the fix actually fix the issue?
Sure.
> o In what version was the bug introduced? This helps backporters.
This patch is only for ar9003 and its support is added only
recently. No released kernel has the support for this chip.
>
> > +#define ATH9K_CHECK_AUTO_SLEEP(__sc) \
> > + (__sc->ps_enabled && \
> > + (__sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_AUTOSLEEP))
>
> Like Andrew Morton says: use C instead of CPP. Meaning that this can
> be an inline function instead of a macro.
will do, thanks.
Vasanth
prev parent reply other threads:[~2010-05-23 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 0:31 [PATCH] ath9k: Fix rx of mcast/bcast frames in PS mode with auto sleep Vasanthakumar Thiagarajan
2010-05-22 19:08 ` Kalle Valo
2010-05-23 6:48 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523064814.GB21298@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox