From: Kalle Valo <kvalo@adurom.com>
To: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Fix rx of mcast/bcast frames in PS mode with auto sleep
Date: Sat, 22 May 2010 22:08:48 +0300 [thread overview]
Message-ID: <8739xjiwjj.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1274229062-10412-1-git-send-email-vasanth@atheros.com> (Vasanthakumar Thiagarajan's message of "Tue\, 18 May 2010 17\:31\:02 -0700")
Vasanthakumar Thiagarajan <vasanth@atheros.com> writes:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Please describe more, this isn't very informative (if any). Especially
try to answer in the commit log:
o What was the original bug? How and why did it happen?
o How was it visible to the user?
o How does the fix actually fix the issue?
o In what version was the bug introduced? This helps backporters.
Powersave in 802.11 is very fragile and more information there is, the
easier it is to handle the issues.
> +#define ATH9K_CHECK_AUTO_SLEEP(__sc) \
> + (__sc->ps_enabled && \
> + (__sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_AUTOSLEEP))
Like Andrew Morton says: use C instead of CPP. Meaning that this can
be an inline function instead of a macro.
--
Kalle Valo
next prev parent reply other threads:[~2010-05-22 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 0:31 [PATCH] ath9k: Fix rx of mcast/bcast frames in PS mode with auto sleep Vasanthakumar Thiagarajan
2010-05-22 19:08 ` Kalle Valo [this message]
2010-05-23 6:48 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739xjiwjj.fsf@purkki.valot.fi \
--to=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox