Linux wireless drivers development
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ath9k_hw: Fix magnitude/phase coeff correction
Date: Tue, 13 Sep 2011 13:32:26 -0400	[thread overview]
Message-ID: <20110913173226.GF11772@tuxdriver.com> (raw)
In-Reply-To: <1315320530-2733-1-git-send-email-rmanohar@qca.qualcomm.com>

On Tue, Sep 06, 2011 at 08:18:50PM +0530, Rajkumar Manoharan wrote:
> Do the magnitude/phase coeff correction only if the outlier
> is detected.
> 
> Cc: stable@kernel.org
> Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath9k/ar9003_calib.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> index fa35a02..ee3a8a2 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> @@ -643,8 +643,9 @@ static void ar9003_hw_detect_outlier(int *mp_coeff, int nmeasurement,
>  			outlier_idx = max_idx;
>  		else
>  			outlier_idx = min_idx;
> +
> +		mp_coeff[outlier_idx] = mp_avg;
>  	}
> -	mp_coeff[outlier_idx] = mp_avg;
>  }
>  
>  static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah,

What is the effect of the bug being fixed here?  Is this fix intended for 3.1?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-09-13 17:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06 14:48 [PATCH] ath9k_hw: Fix magnitude/phase coeff correction Rajkumar Manoharan
2011-09-13 17:32 ` John W. Linville [this message]
2011-09-14  3:49   ` Rajkumar Manoharan
2011-09-14  8:45     ` Kalle Valo
2011-09-14  9:03       ` Rajkumar Manoharan
2011-09-14 16:54         ` Rajkumar Manoharan
2011-09-14 16:54           ` John W. Linville
2011-09-14 13:27     ` John W. Linville
2011-09-14 13:47       ` Adrian Chadd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913173226.GF11772@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanohar@qca.qualcomm.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox