From: "John W. Linville" <linville@tuxdriver.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, kvalo@adurom.com
Subject: Re: [PATCH] ath9k_hw: Fix magnitude/phase coeff correction
Date: Wed, 14 Sep 2011 12:54:47 -0400 [thread overview]
Message-ID: <20110914165446.GB2485@tuxdriver.com> (raw)
In-Reply-To: <20110914165426.GA13088@vmraj-lnx.users.atheros.com>
On Wed, Sep 14, 2011 at 10:24:27PM +0530, Rajkumar Manoharan wrote:
> On Wed, Sep 14, 2011 at 02:33:22PM +0530, Rajkumar Manoharan wrote:
> > On Wed, Sep 14, 2011 at 11:45:20AM +0300, Kalle Valo wrote:
> > > Rajkumar Manoharan <rmanohar@qca.qualcomm.com> writes:
> > >
> > > > On Tue, Sep 13, 2011 at 01:32:26PM -0400, John W. Linville wrote:
> > > >> On Tue, Sep 06, 2011 at 08:18:50PM +0530, Rajkumar Manoharan wrote:
> > > >> > Do the magnitude/phase coeff correction only if the outlier
> > > >> > is detected.
> > > >> >
> > > >> > Cc: stable@kernel.org
> > > >> > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> > > >> > ---
> > > >> >
> > > >> > static void ar9003_hw_tx_iqcal_load_avg_2_passes(struct ath_hw *ah,
> > > >>
> > > >> What is the effect of the bug being fixed here? Is this fix intended for 3.1?
> > > >
> > > > The first entry of phase/mag got changed to average if outlier is
> > > > not detected. This patch ensures to update appropriate index of
> > > > magnitude/phase. This patch is applicable from 3.0 onwards.
> > >
> > > Sorry, but this doesn't tell much. What's the user visible change
> > > with this patch? Better sensitivity, less transmission errors or what?
> > >
> > It has minor impact because of this bug, an undesirable Tx IQ correction value
> > will be assigned to Tx gain settings wheen outlier is not happened. The impacts
> > on overall system throughput should be very minor.
> >
> John,
>
> Not doing the calibrations in proper manner could impact performance in congested
> network. Maybe i should update the impact in the commit log. Wanna send me v2
> patch?
Please.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-09-14 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 14:48 [PATCH] ath9k_hw: Fix magnitude/phase coeff correction Rajkumar Manoharan
2011-09-13 17:32 ` John W. Linville
2011-09-14 3:49 ` Rajkumar Manoharan
2011-09-14 8:45 ` Kalle Valo
2011-09-14 9:03 ` Rajkumar Manoharan
2011-09-14 16:54 ` Rajkumar Manoharan
2011-09-14 16:54 ` John W. Linville [this message]
2011-09-14 13:27 ` John W. Linville
2011-09-14 13:47 ` Adrian Chadd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914165446.GB2485@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox