* re: rndis_wlan: split getting current channel to separate function
@ 2012-02-29 6:32 Dan Carpenter
2012-02-29 8:09 ` Jussi Kivilinna
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-02-29 6:32 UTC (permalink / raw)
To: jussi.kivilinna; +Cc: linux-wireless
Hello Jussi,
The patch b5257c952: "rndis_wlan: workaround device not returning bss
for currently connected AP" from Nov 9, 2011, leads to the following
warning:
drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast to restricted __le16
drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast from restricted __le32
1372
1373 if (beacon_interval)
1374 *beacon_interval = le16_to_cpu(config.beacon_period);
1375 return channel;
The problem is that config.beacon_period is declared as le32 but we're
using it as le16.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* re: rndis_wlan: split getting current channel to separate function
2012-02-29 6:32 rndis_wlan: split getting current channel to separate function Dan Carpenter
@ 2012-02-29 8:09 ` Jussi Kivilinna
2012-02-29 8:47 ` Jussi Kivilinna
0 siblings, 1 reply; 3+ messages in thread
From: Jussi Kivilinna @ 2012-02-29 8:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-wireless
Quoting Dan Carpenter <dan.carpenter@oracle.com>:
> Hello Jussi,
>
> The patch b5257c952: "rndis_wlan: workaround device not returning bss
> for currently connected AP" from Nov 9, 2011, leads to the following
> warning:
> drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast to restricted __le16
> drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast from
> restricted __le32
>
> 1372
> 1373 if (beacon_interval)
> 1374 *beacon_interval = le16_to_cpu(config.beacon_period);
> 1375 return channel;
>
> The problem is that config.beacon_period is declared as le32 but we're
> using it as le16.
Ah yes, I'll post patch soon. Thanks.
-Jussi
>
> regards,
> dan carpenter
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* re: rndis_wlan: split getting current channel to separate function
2012-02-29 8:09 ` Jussi Kivilinna
@ 2012-02-29 8:47 ` Jussi Kivilinna
0 siblings, 0 replies; 3+ messages in thread
From: Jussi Kivilinna @ 2012-02-29 8:47 UTC (permalink / raw)
To: Jussi Kivilinna; +Cc: Dan Carpenter, linux-wireless
Quoting Jussi Kivilinna <jussi.kivilinna@mbnet.fi>:
> Quoting Dan Carpenter <dan.carpenter@oracle.com>:
>
>> Hello Jussi,
>>
>> The patch b5257c952: "rndis_wlan: workaround device not returning bss
>> for currently connected AP" from Nov 9, 2011, leads to the following
>> warning:
>> drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast to
>> restricted __le16
>> drivers/net/wireless/rndis_wlan.c:1374:36: warning: cast from
>> restricted __le32
>>
>> 1372
>> 1373 if (beacon_interval)
>> 1374 *beacon_interval = le16_to_cpu(config.beacon_period);
>> 1375 return channel;
>>
>> The problem is that config.beacon_period is declared as le32 but we're
>> using it as le16.
>
> Ah yes, I'll post patch soon. Thanks.
Well.. I ran into interesting problem where driver stops working if I
correct le16_to_cpu to le32_to_cpu. But if I instead pass
beacon_interval=0 to cfg80211, driver start working again. So this is
bug fixing another problem, I'll check it more throughtly when I have
more time.
-Jussi
>
> -Jussi
>
>>
>> regards,
>> dan carpenter
>>
>>
>>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-29 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 6:32 rndis_wlan: split getting current channel to separate function Dan Carpenter
2012-02-29 8:09 ` Jussi Kivilinna
2012-02-29 8:47 ` Jussi Kivilinna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox