* [patch] mwifiex: use GFP_ATOMIC under spin lock
@ 2012-08-09 6:57 Dan Carpenter
2012-08-09 18:19 ` Bing Zhao
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-08-09 6:57 UTC (permalink / raw)
To: Bing Zhao; +Cc: John W. Linville, linux-wireless, kernel-janitors
We're holding the sta_list_spinlock here so we can't sleep.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/mwifiex/uap_event.c b/drivers/net/wireless/mwifiex/uap_event.c
index 14d4f04..ca4a1f3 100644
--- a/drivers/net/wireless/mwifiex/uap_event.c
+++ b/drivers/net/wireless/mwifiex/uap_event.c
@@ -63,7 +63,7 @@ mwifiex_add_sta_entry(struct mwifiex_private *priv, u8 *mac)
if (node)
goto done;
- node = kzalloc(sizeof(struct mwifiex_sta_node), GFP_KERNEL);
+ node = kzalloc(sizeof(struct mwifiex_sta_node), GFP_ATOMIC);
if (!node)
goto done;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [patch] mwifiex: use GFP_ATOMIC under spin lock
2012-08-09 6:57 [patch] mwifiex: use GFP_ATOMIC under spin lock Dan Carpenter
@ 2012-08-09 18:19 ` Bing Zhao
0 siblings, 0 replies; 2+ messages in thread
From: Bing Zhao @ 2012-08-09 18:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: John W. Linville, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Hi Dan,
Thanks for the patch.
> We're holding the sta_list_spinlock here so we can't sleep.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Bing Zhao <bzhao@marvell.com>
Regards,
Bing
>
> diff --git a/drivers/net/wireless/mwifiex/uap_event.c b/drivers/net/wireless/mwifiex/uap_event.c
> index 14d4f04..ca4a1f3 100644
> --- a/drivers/net/wireless/mwifiex/uap_event.c
> +++ b/drivers/net/wireless/mwifiex/uap_event.c
> @@ -63,7 +63,7 @@ mwifiex_add_sta_entry(struct mwifiex_private *priv, u8 *mac)
> if (node)
> goto done;
>
> - node = kzalloc(sizeof(struct mwifiex_sta_node), GFP_KERNEL);
> + node = kzalloc(sizeof(struct mwifiex_sta_node), GFP_ATOMIC);
> if (!node)
> goto done;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-09 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-09 6:57 [patch] mwifiex: use GFP_ATOMIC under spin lock Dan Carpenter
2012-08-09 18:19 ` Bing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox