* [PATCH] cw1200: Fix incorrect endianness annotation in a header field
@ 2013-07-20 4:02 Solomon Peachy
2013-07-20 6:12 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Solomon Peachy @ 2013-07-20 4:02 UTC (permalink / raw)
To: linux-wireless; +Cc: Solomon Peachy
Note that the driver doesn't directly use this field, but it should be
correctly defined in any case.
I'd like to see this in 3.11-rc
Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
---
drivers/net/wireless/cw1200/wsm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/cw1200/wsm.h b/drivers/net/wireless/cw1200/wsm.h
index 7afc613..48086e8 100644
--- a/drivers/net/wireless/cw1200/wsm.h
+++ b/drivers/net/wireless/cw1200/wsm.h
@@ -832,7 +832,7 @@ struct wsm_tx {
/* the MSDU shall be terminated. Overrides the global */
/* dot11MaxTransmitMsduLifeTime setting [optional] */
/* Device will set the default value if this is 0. */
- u32 expire_time;
+ __le32 expire_time;
/* WSM_HT_TX_... */
__le32 ht_tx_parameters;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cw1200: Fix incorrect endianness annotation in a header field
2013-07-20 4:02 [PATCH] cw1200: Fix incorrect endianness annotation in a header field Solomon Peachy
@ 2013-07-20 6:12 ` Kalle Valo
2013-07-20 11:55 ` Solomon Peachy
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2013-07-20 6:12 UTC (permalink / raw)
To: Solomon Peachy; +Cc: linux-wireless
Solomon Peachy <pizza@shaftnet.org> writes:
> Note that the driver doesn't directly use this field, but it should be
> correctly defined in any case.
>
> I'd like to see this in 3.11-rc
Comment referring to releases should be after "---" line so that they
don't end up in the commit log.
And besides, I don't think this is important enough for -rc. I doubt
there are users who absolutely need this quickly and this patch can wait
for the next merge window.
> Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
> ---
<--- Add the comment here.
> drivers/net/wireless/cw1200/wsm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cw1200/wsm.h b/drivers/net/wireless/cw1200/wsm.h
> index 7afc613..48086e8 100644
> --- a/drivers/net/wireless/cw1200/wsm.h
> +++ b/drivers/net/wireless/cw1200/wsm.h
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cw1200: Fix incorrect endianness annotation in a header field
2013-07-20 6:12 ` Kalle Valo
@ 2013-07-20 11:55 ` Solomon Peachy
0 siblings, 0 replies; 3+ messages in thread
From: Solomon Peachy @ 2013-07-20 11:55 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Sat, Jul 20, 2013 at 09:12:16AM +0300, Kalle Valo wrote:
> Comment referring to releases should be after "---" line so that they
> don't end up in the commit log.
Duly noted.
> And besides, I don't think this is important enough for -rc. I doubt
> there are users who absolutely need this quickly and this patch can wait
> for the next merge window.
This is effectively a documentation fix, since the driver
currently sets that field to '0' (ie "use firmware default").
That said, while it's trivial, it's a fix nonetheless.
As long as the patch doesn't get dropped. I have my preference, but
I'll leave exactly when it gets merged to Linville's disretion.
(I have some not-yet-finished new work that's clearly -next material,
and two patches that need to go into -backports, as soon as I figure
out how to integrate that)
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Delray Beach, FL ^^ (email/xmpp) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-20 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-20 4:02 [PATCH] cw1200: Fix incorrect endianness annotation in a header field Solomon Peachy
2013-07-20 6:12 ` Kalle Valo
2013-07-20 11:55 ` Solomon Peachy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox