From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath9k: fix SC_OP_INVALID test in ath9k_tx99_init()
Date: Wed, 6 Nov 2013 09:50:30 +0300 [thread overview]
Message-ID: <20131106065030.GR26669@mwanda> (raw)
In-Reply-To: <21113.53593.471557.385898@gargle.gargle.HOWL>
On Wed, Nov 06, 2013 at 10:49:21AM +0530, Sujith Manoharan wrote:
> Dan Carpenter wrote:
> > SC_OP_INVALID is zero so the test is always false. We're supposed to be
> > testing the lowest bit instead.
> >
> > Fixes: 89f927af7f33 ('ath9k: add TX99 support')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> > index 74f452c..7ad4e11 100644
> > --- a/drivers/net/wireless/ath/ath9k/main.c
> > +++ b/drivers/net/wireless/ath/ath9k/main.c
> > @@ -2456,7 +2456,7 @@ int ath9k_tx99_init(struct ath_softc *sc)
> > struct ath_tx_control txctl;
> > int r;
> >
> > - if (sc->sc_flags & SC_OP_INVALID) {
> > + if (test_bit(SC_OP_INVALID, &sc->sc_flags)) {
> > ath_err(common,
> > "driver is in invalid state unable to use TX99");
> > return -EINVAL;
>
> Nice catch.
>
> The tx99 code in ath9k has been moved to a separate file, is it okay if I adopt
> this patch and update it ?
>
Yeah. That's fine.
regards,
dan carpenter
next prev parent reply other threads:[~2013-11-06 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:20 [patch] ath9k: fix SC_OP_INVALID test in ath9k_tx99_init() Dan Carpenter
2013-11-06 5:19 ` Sujith Manoharan
2013-11-06 6:50 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-14 10:13 [PATCH] " Sujith Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106065030.GR26669@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox