Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 3/8] ath10k: fix name of target_ps module parameter
Date: Tue, 25 Mar 2014 11:15:17 +0200	[thread overview]
Message-ID: <20140325091517.16651.58082.stgit@potku.adurom.net> (raw)
In-Reply-To: <20140325091311.16651.15747.stgit@potku.adurom.net>

The parameter name was ath10k_target_ps, but actually it should be just
target_ps. Module parameter names should not use the ath10k_ prefix.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/pci.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index d968aedc4863..2c5a83d2748a 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -44,12 +44,12 @@ enum ath10k_pci_reset_mode {
 	ATH10K_PCI_RESET_WARM_ONLY = 1,
 };
 
-static unsigned int ath10k_target_ps;
+static unsigned int ath10k_pci_target_ps;
 static unsigned int ath10k_pci_irq_mode = ATH10K_PCI_IRQ_AUTO;
 static unsigned int ath10k_pci_reset_mode = ATH10K_PCI_RESET_AUTO;
 
-module_param(ath10k_target_ps, uint, 0644);
-MODULE_PARM_DESC(ath10k_target_ps, "Enable ath10k Target (SoC) PS option");
+module_param_named(target_ps, ath10k_pci_target_ps, uint, 0644);
+MODULE_PARM_DESC(target_ps, "Enable ath10k Target (SoC) PS option");
 
 module_param_named(irq_mode, ath10k_pci_irq_mode, uint, 0644);
 MODULE_PARM_DESC(irq_mode, "0: auto, 1: legacy, 2: msi (default: 0)");
@@ -2524,7 +2524,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
 		goto err_ar_pci;
 	}
 
-	if (ath10k_target_ps)
+	if (ath10k_pci_target_ps)
 		set_bit(ATH10K_PCI_FEATURE_SOC_POWER_SAVE, ar_pci->features);
 
 	ath10k_pci_dump_features(ar_pci);


  parent reply	other threads:[~2014-03-25  9:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  9:14 [PATCH 0/8] ath10k: small cleanups to pci.c Kalle Valo
2014-03-25  9:15 ` [PATCH 1/8] ath10k: cleanup ath10k_pci_wait_for_target_init() Kalle Valo
2014-03-25  9:32   ` Michal Kazior
2014-03-26  9:28     ` Kalle Valo
2014-03-26  9:52       ` Michal Kazior
2014-03-26 11:10         ` Kalle Valo
2014-03-25  9:15 ` [PATCH 2/8] ath10k: add module parameter to disable cold reset Kalle Valo
2014-03-25  9:15 ` Kalle Valo [this message]
2014-03-25  9:15 ` [PATCH 4/8] ath10k: advertise only firmware API 2 files Kalle Valo
2014-03-25  9:15 ` [PATCH 5/8] ath10k: delete ar_pci->fw_indicator_address Kalle Valo
2014-03-25  9:15 ` [PATCH 6/8] ath10k: improve pci debug messages Kalle Valo
2014-03-25  9:15 ` [PATCH 7/8] ath10k: add module parameter values to the pci info print Kalle Valo
2014-03-25  9:15 ` [PATCH 8/8] ath10k: print chip id during boot Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325091517.16651.58082.stgit@potku.adurom.net \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox