* [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()
@ 2017-07-12 9:32 Arend van Spriel
2017-07-12 14:29 ` Bob Copeland
2017-07-21 7:41 ` [for-4.13] " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Arend van Spriel @ 2017-07-12 9:32 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Arend van Spriel
Recent change in brcmf_sdio_txpkt_hdalign() changed the
behavior and now always returns 0. This resulted in a
regression which basically renders the device useless.
Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
Reported-by: S. Gilles <sgilles@math.umd.edu>
Tested-by: S. Gilles <sgilles@math.umd.edu>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index fbcbb43..c3ecec6 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -2053,12 +2053,13 @@ static int brcmf_sdio_txpkt_hdalign(struct brcmf_sdio *bus, struct sk_buff *pkt)
atomic_inc(&stats->pktcow_failed);
return -ENOMEM;
}
+ head_pad = 0;
}
skb_push(pkt, head_pad);
dat_buf = (u8 *)(pkt->data);
}
memset(dat_buf, 0, head_pad + bus->tx_hdrlen);
- return 0;
+ return head_pad;
}
/**
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()
2017-07-12 9:32 [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign() Arend van Spriel
@ 2017-07-12 14:29 ` Bob Copeland
2017-07-12 14:57 ` Arend van Spriel
2017-07-21 7:41 ` [for-4.13] " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Bob Copeland @ 2017-07-12 14:29 UTC (permalink / raw)
To: Arend van Spriel; +Cc: Kalle Valo, linux-wireless
On Wed, Jul 12, 2017 at 10:32:48AM +0100, Arend van Spriel wrote:
> Recent change in brcmf_sdio_txpkt_hdalign() changed the
> behavior and now always returns 0. This resulted in a
> regression which basically renders the device useless.
Should this go via netdev as well, or just wait for Kalle (returning
on Sunday)?
--
Bob Copeland %% https://bobcopeland.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()
2017-07-12 14:29 ` Bob Copeland
@ 2017-07-12 14:57 ` Arend van Spriel
0 siblings, 0 replies; 4+ messages in thread
From: Arend van Spriel @ 2017-07-12 14:57 UTC (permalink / raw)
To: Bob Copeland; +Cc: Kalle Valo, linux-wireless
On 12-07-17 16:29, Bob Copeland wrote:
> On Wed, Jul 12, 2017 at 10:32:48AM +0100, Arend van Spriel wrote:
>> Recent change in brcmf_sdio_txpkt_hdalign() changed the
>> behavior and now always returns 0. This resulted in a
>> regression which basically renders the device useless.
>
> Should this go via netdev as well, or just wait for Kalle (returning
> on Sunday)?
Hi Bob,
This regression got introduced recently so the issue will pop-up in
v4.13-rc1 hence I figured we can wait for Kalle with this one.
Regards,
Arend
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()
2017-07-12 9:32 [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign() Arend van Spriel
2017-07-12 14:29 ` Bob Copeland
@ 2017-07-21 7:41 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-07-21 7:41 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: linux-wireless, Arend van Spriel
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> Recent change in brcmf_sdio_txpkt_hdalign() changed the
> behavior and now always returns 0. This resulted in a
> regression which basically renders the device useless.
>
> Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
> Reported-by: S. Gilles <sgilles@math.umd.edu>
> Tested-by: S. Gilles <sgilles@math.umd.edu>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers.git, thanks.
0a16628212b8 brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign()
--
https://patchwork.kernel.org/patch/9836383/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-21 7:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-12 9:32 [PATCH for-4.13] brcmfmac: fix regression in brcmf_sdio_txpkt_hdalign() Arend van Spriel
2017-07-12 14:29 ` Bob Copeland
2017-07-12 14:57 ` Arend van Spriel
2017-07-21 7:41 ` [for-4.13] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox