From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Avraham Stern <avraham.stern@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 03/10] iwlwifi: mvm: send all non-bufferable frames on the probe queue
Date: Fri, 8 Sep 2017 12:12:49 +0300 [thread overview]
Message-ID: <20170908091256.25279-4-luca@coelho.fi> (raw)
In-Reply-To: <20170908091256.25279-1-luca@coelho.fi>
From: Avraham Stern <avraham.stern@intel.com>
AP interfaces now send all non-bufferable frames using the broadcast
station. Thus allow them to use the probe queue and don't warn about
it.
Fixes: eb045e6e0389 ("iwlwifi: mvm: Avoid deferring non bufferable frames")
Signed-off-by: Avraham Stern <avraham.stern@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
index 172b5e63d3fb..6f2e2af23219 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
@@ -564,8 +564,8 @@ static int iwl_mvm_get_ctrl_vif_queue(struct iwl_mvm *mvm,
case NL80211_IFTYPE_AP:
case NL80211_IFTYPE_ADHOC:
/*
- * Handle legacy hostapd as well, where station will be added
- * only just before sending the association response.
+ * Non-bufferable frames use the broadcast station, thus they
+ * use the probe queue.
* Also take care of the case where we send a deauth to a
* station that we don't have, or similarly an association
* response (with non-success status) for a station we can't
@@ -573,9 +573,9 @@ static int iwl_mvm_get_ctrl_vif_queue(struct iwl_mvm *mvm,
* Also, disassociate frames might happen, particular with
* reason 7 ("Class 3 frame received from nonassociated STA").
*/
- if (ieee80211_is_probe_resp(fc) || ieee80211_is_auth(fc) ||
- ieee80211_is_deauth(fc) || ieee80211_is_assoc_resp(fc) ||
- ieee80211_is_disassoc(fc))
+ if (ieee80211_is_mgmt(fc) &&
+ (!ieee80211_is_bufferable_mmpdu(fc) ||
+ ieee80211_is_deauth(fc) || ieee80211_is_disassoc(fc)))
return mvm->probe_queue;
if (info->hw_queue == info->control.vif->cab_queue)
return mvmvif->cab_queue;
--
2.14.1
next prev parent reply other threads:[~2017-09-08 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 9:12 [PATCH 00/10] iwlwifi: fixes intended for 4.14 2017-09-08 Luca Coelho
2017-09-08 9:12 ` [PATCH 01/10] iwlwifi: mvm: fix wowlan resume failed to load INIT ucode Luca Coelho
2017-09-08 9:12 ` [PATCH 02/10] iwlwifi: mvm: Flush non STA TX queues Luca Coelho
2017-09-08 9:12 ` Luca Coelho [this message]
2017-09-08 9:12 ` [PATCH 04/10] iwlwifi: mvm: change state when queueing agg start work Luca Coelho
2017-09-08 9:12 ` [PATCH 05/10] iwlwifi: mvm: wake the correct mac80211 queue Luca Coelho
2017-09-08 9:12 ` [PATCH 06/10] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD Luca Coelho
2017-09-08 9:12 ` [PATCH 07/10] iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses Luca Coelho
2017-09-08 9:12 ` [PATCH 08/10] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common() Luca Coelho
2017-09-08 9:12 ` [PATCH 09/10] iwlwifi: mvm: set status before calling iwl_mvm_send_cmd_status() Luca Coelho
2017-09-08 9:12 ` [PATCH 10/10] iwlwifi: mvm: fix reorder buffer for 9000 devices Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908091256.25279-4-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=avraham.stern@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox